[GitHub] [airflow] ashb commented on a change in pull request #5381: AIRFLOW-4740 make default_args end_date permissive

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5381: AIRFLOW-4740 make default_args end_date permissive
URL: https://github.com/apache/airflow/pull/5381#discussion_r292373017
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -203,6 +203,12 @@ def test_dag_topological_sort(self):
 
         self.assertEqual(tuple(), dag.topological_sort())
 
+    def test_dag_naive_start_date_string(self):
+        DAG('DAG', default_args={'start_date': '2019-06-01'})
+
+    def test_dag_naive_start_end_dates_strings(self):
+        DAG('DAG', default_args={'start_date': '2019-06-01', 'end_date': '2019-06-05'})
 
 Review comment:
   Could you add a test case that covers a non-default TZ start_date and a string end_date to check that the TZ is applied correctly to end_date?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services