Re: [PR] Introduce OutputBuilder in Java SDK [beam]

["kellen (via GitHub)" <gi...@apache.org>]

kellen commented on code in PR #34902:
URL: https://github.com/apache/beam/pull/34902#discussion_r2527777237


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1924,6 +1932,17 @@ public TimerMap timerFamily(String timerFamilyId) {
   private class NonWindowObservingProcessBundleContext
       extends NonWindowObservingProcessBundleContextBase {
 
+    @Override
+    public OutputBuilder<OutputT> builder(OutputT value) {
+      return WindowedValues.builder(currentElement)
+          .withValue(value)
+          .setReceiver(
+              windowedValue -> {
+                checkTimestamp(windowedValue.getTimestamp());

Review Comment:
   Hey @kennknowles Can you explain the reasoning about checking the timestamp here? In Scio we have some DoFns that propagate the element timestamp and this additional check breaks. Not sure if we've been doing the wrong thing or not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org