You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/28 10:37:46 UTC
[jira] [Commented] (CB-9370) Cordova-js tests are failing on node
0.12
[ https://issues.apache.org/jira/browse/CB-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718218#comment-14718218 ]
ASF GitHub Bot commented on CB-9370:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-js/pull/127
CB-9370 Switches to another jsdom dependency to avoid package installation issues
This resolves build failures on AppVeyor (https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.911).
See [CB-9370](https://issues.apache.org/jira/browse/CB-9370) for details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-9370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
----
commit 9d90784c28284618fb3cb2449cdc3960470ff842
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-08-28T08:33:08Z
CB-9370 Changes jsdom dependency to avoid package installation issues
----
> Cordova-js tests are failing on node 0.12
> -----------------------------------------
>
> Key: CB-9370
> URL: https://issues.apache.org/jira/browse/CB-9370
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 4.1.0
> Environment: Windows/Mac OSX machine,
> Node JS 0.12.7
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: cordova-js
> Fix For: 4.1.0
>
>
> Since https://github.com/apache/cordova-js/pull/118 unit tests for cordova-js started failing on AppVeyor CI with unclear message {{Fatal error: Cannot set property length of [object Object] which has only a getter}}.
> It looks like the origin of failures - updated NodeJS version on AppVeyor build machines. Failure also can be reproduced on local machine with Node@0.12.5 installed.
> The reason of failures - is outdated {{jsdom-nogyp}} dependency (last updated about 2 years ago). The solution is to replace {{jsdom-nogyp}} with original {{node-jsdom}}, which works fine with node@12.x. It also would be great to test such cases through CI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org