[GitHub] [spark] cloud-fan commented on a diff in pull request #42450: [SPARK-44773][SQL] Code-gen CodegenFallback expression in WholeStageCodegen if possible

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42450:
URL: https://github.com/apache/spark/pull/42450#discussion_r1298325776


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala:
##########
@@ -150,15 +150,15 @@ class EquivalentExpressions(
   //   1. CodegenFallback: it's children will not be used to generate code (call eval() instead)

Review Comment:
   I think this is still true. Why do we change the code here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org