You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2024/02/04 12:45:00 UTC
[jira] [Comment Edited] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[ https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814080#comment-17814080 ]
Jacques Le Roux edited comment on OFBIZ-12888 at 2/4/24 12:44 PM:
------------------------------------------------------------------
It's only a matter of performance for the hook. I'd like to have [~danwatford] opinon about removing the compileGroovyScriptsGroovy Gradle task...
BTW, if I understand well the fix only removes a duplicate. Does the duplicate pose other problems than just being a duplicate?
Maybe it's a lof of duplicates and not only 1 duplicate?
If it's the case, apart that, what are the issues?
was (Author: jacques.le.roux):
It's only a matter of performance for the hook. I'd like to have [~danwatford] opinon about removing the compileGroovyScriptsGroovy Gradle task...
BTW, if I understand well the fix only removes a duplicate. Does the duplicate pose other problems than just being a duplicate?
> Gradle eclipse target produces duplicate build path entries in .classpath
> -------------------------------------------------------------------------
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
> Affects Versions: Upcoming Branch
> Reporter: Michael Brohl
> Assignee: Michael Brohl
> Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push) everything seems to work fine, tests are working and the codenarc Main and Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)