[GitHub] [incubator-pekko-grpc] He-Pin commented on a diff in pull request #168: [DRAFT] upgrade protobuf-java

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on code in PR #168:
URL: https://github.com/apache/incubator-pekko-grpc/pull/168#discussion_r1299548939


##########
project/Dependencies.scala:
##########
@@ -36,7 +36,7 @@ object Dependencies {
     // If changing this, remember to update protoc plugin version to align in
     // maven-plugin/src/main/maven/plugin.xml and org.apache.pekko.grpc.sbt.PekkoGrpcPlugin
     val googleProtoc = "3.20.1" // checked synced by VersionSyncCheckPlugin

Review Comment:
   Can this two version be the same?



##########
project/Dependencies.scala:
##########
@@ -36,7 +36,7 @@ object Dependencies {
     // If changing this, remember to update protoc plugin version to align in
     // maven-plugin/src/main/maven/plugin.xml and org.apache.pekko.grpc.sbt.PekkoGrpcPlugin
     val googleProtoc = "3.20.1" // checked synced by VersionSyncCheckPlugin

Review Comment:
   Can this two versions be the same?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org