You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/04 06:27:36 UTC

[GitHub] [pulsar] Demogorgon314 opened a new pull request, #13975: [fix][managed-ledger] Fix when nextValidLedger is null caused NPE

Demogorgon314 opened a new pull request, #13975:
URL: https://github.com/apache/pulsar/pull/13975

   ### Motivation
   
   When the `nextValidLedger` is null, `newPosition.getLedgerId() == nextValidLedger` will unboxing of 'nextValidLedger' may produce 'NullPointerException'.
   
   Fortunately, it doesn't cause any behavior bug, it just prints into the log.
   
   NPE log:
   ```java
   2022-01-27T12:34:39,239+0800 [pulsar-io-6-1] WARN  org.apache.bookkeeper.mledger.impl.ManagedCursorImpl - Failed to get ledger entries while setting mark-delete-position
   java.lang.NullPointerException: null
   	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.asyncMarkDelete(ManagedCursorImpl.java:1699) [classes/:?]
   	at org.apache.pulsar.broker.service.persistent.PersistentSubscription.acknowledgeMessage(PersistentSubscription.java:395) [classes/:?]
   	at org.apache.pulsar.broker.service.Consumer.messageAcked(Consumer.java:379) [classes/:?]
   	at org.apache.pulsar.broker.service.ServerCnx.handleAck(ServerCnx.java:1449) [classes/:?]
   	at org.apache.pulsar.common.protocol.PulsarDecoder.channelRead(PulsarDecoder.java:145) [classes/:?]
   ```
   ### Modifications
   
   Check `nextValidLedger ` is null.
   
   ### Documentation
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
   This is a bug fix, no need doc.
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #13975: [fix][managed-ledger] Fix when nextValidLedger is null caused NPE

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #13975:
URL: https://github.com/apache/pulsar/pull/13975#issuecomment-1087038401

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 closed pull request #13975: [fix][managed-ledger] Fix when nextValidLedger is null caused NPE

Posted by GitBox <gi...@apache.org>.
Demogorgon314 closed pull request #13975: [fix][managed-ledger] Fix when nextValidLedger is null caused NPE
URL: https://github.com/apache/pulsar/pull/13975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Demogorgon314 commented on pull request #13975: [fix][managed-ledger] Fix when nextValidLedger is null caused NPE

Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #13975:
URL: https://github.com/apache/pulsar/pull/13975#issuecomment-1091011345

   @codelipenghui @BewareMyPower The CI is passed. Please take a look if you have time, thanks : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #13975: [fix][managed-ledger] Fix when nextValidLedger is null caused NPE

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #13975:
URL: https://github.com/apache/pulsar/pull/13975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org