[jira] [Commented] (HADOOP-11484) Fails to build on ARM AARCH64 due to x86 asm statements

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278955#comment-14278955 ] 

Hadoop QA commented on HADOOP-11484:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12692544/HADOOP-11484.001.patch
  against trunk revision ce29074.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5413//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5413//console

This message is automatically generated.

> Fails to build on ARM AARCH64 due to x86 asm statements
> -------------------------------------------------------
>
>                 Key: HADOOP-11484
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11484
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: trunk-win
>         Environment: ARM aarch64 development board
>            Reporter: Edward Nevill
>            Assignee: Edward Nevill
>              Labels: build
>             Fix For: trunk-win
>
>         Attachments: HADOOP-11484.001.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hadoop fails to build on ARM aarch64 (or any non x86 platform) because of the following in
> hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/primitives.h
> {noformat}
> /**
>  * little-endian to big-endian or vice versa
>  */
> inline uint32_t bswap(uint32_t val) {
>   __asm__("bswap %0" : "=r" (val) : "0" (val));
>   return val;
> }
> inline uint64_t bswap64(uint64_t val) {
> #ifdef __X64
>   __asm__("bswapq %0" : "=r" (val) : "0" (val));
> #else
>   uint64_t lower = val & 0xffffffffU;
>   uint32_t higher = (val >> 32) & 0xffffffffU;
>   lower = bswap(lower);
>   higher = bswap(higher);
>   return (lower << 32) + higher;
> #endif
>   return val;
> }
> {noformat}
> The following also fails in
> hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/Checksum.cc
> {noformat}
> static uint32_t cpuid(uint32_t eax_in) {
>   uint32_t eax, ebx, ecx, edx;
> #  if defined(__PIC__) && !defined(__LP64__)
> // 32-bit PIC code uses the ebx register for the base offset --
> // have to save and restore it on the stack
>   asm("pushl %%ebx\n\t"
>       "cpuid\n\t"
>       "movl %%ebx, %[ebx]\n\t"
>       "popl %%ebx" : "=a" (eax), [ebx] "=r"(ebx), "=c"(ecx), "=d"(edx) : "a" (eax_in) 
>       : "cc");
> #  else
>   asm("cpuid" : "=a" (eax), "=b"(ebx), "=c"(ecx), "=d"(edx) : "a"(eax_in)
>       : "cc");
> #  endif
>   return ecx;
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)