You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:54:51 UTC
Review Request 61293: Removed `glog` configuration from `libprocess`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61293/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This is no longer necessary as `libprocess` transitively links to `glog`
via the `stout` library.
Diffs
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 3e621f97b683012beca5705fbf3e4000d686f3ab
Diff: https://reviews.apache.org/r/61293/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61293: Removed `glog` configuration from
`libprocess`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61293/#review184443
-----------------------------------------------------------
Ship it!
I'm going to squash all these reviews into this one. Reason being that the final one listed will simply delete most of the files edited by the other ones.
Review: https://reviews.apache.org/r/61296/
Review: https://reviews.apache.org/r/61305/
Review: https://reviews.apache.org/r/61316/
Review: https://reviews.apache.org/r/61319/
Review: https://reviews.apache.org/r/61321/
Review: https://reviews.apache.org/r/61325/
Review: https://reviews.apache.org/r/61329/
Review: https://reviews.apache.org/r/61332/
Review: https://reviews.apache.org/r/61335/
Review: https://reviews.apache.org/r/61338/
Review: https://reviews.apache.org/r/61353/
Review: https://reviews.apache.org/r/61358/
Review: https://reviews.apache.org/r/61348/
Review: https://reviews.apache.org/r/61363/
- Joseph Wu
On Aug. 1, 2017, 5:54 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61293/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:54 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is no longer necessary as `libprocess` transitively links to `glog`
> via the `stout` library.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 3e621f97b683012beca5705fbf3e4000d686f3ab
>
>
> Diff: https://reviews.apache.org/r/61293/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>