You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/13 22:40:40 UTC

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

    [ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097048#comment-15097048 ] 

ASF GitHub Bot commented on FLINK-2871:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1469#discussion_r49654822
  
    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildFirstDescriptor.java ---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.optimizer.operators;
    +
    +import org.apache.flink.api.common.operators.util.FieldList;
    +import org.apache.flink.optimizer.dag.TwoInputNode;
    +import org.apache.flink.optimizer.dataproperties.LocalProperties;
    +import org.apache.flink.optimizer.dataproperties.RequestedLocalProperties;
    +import org.apache.flink.optimizer.plan.Channel;
    +import org.apache.flink.optimizer.plan.DualInputPlanNode;
    +import org.apache.flink.runtime.operators.DriverStrategy;
    +
    +import java.util.Collections;
    +import java.util.List;
    +
    +public class HashFullOuterJoinBuildFirstDescriptor extends AbstractJoinDescriptor {
    +
    +	public HashFullOuterJoinBuildFirstDescriptor(FieldList keys1, FieldList keys2,
    +		boolean broadcastFirstAllowed, boolean broadcastSecondAllowed, boolean repartitionAllowed) {
    --- End diff --
    
    Broadcast-Forward shipping strategies are not valid for full outer joins.
    Hence, the broadcast parameters can be removed.


> Add OuterJoin strategy with HashTable on outer side
> ---------------------------------------------------
>
>                 Key: FLINK-2871
>                 URL: https://issues.apache.org/jira/browse/FLINK-2871
>             Project: Flink
>          Issue Type: New Feature
>          Components: Local Runtime, Optimizer
>    Affects Versions: 0.10.0
>            Reporter: Fabian Hueske
>            Assignee: Chengxiang Li
>            Priority: Minor
>
> Outer joins are currently supported with two local execution strategies:
> - sort-merge join
> - hash join where the hash table is built on the inner side. Hence, this strategy is only supported for left and right outer joins.
> In order to support hash-tables on the outer side, we need a special hash table implementation that gives access to all records which have not been accessed during the probe phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)