You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/11/06 11:28:18 UTC
Review Request 40010: Put authorize logic for teardown into a common
function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The mesos now have authorizeTask, authorizeFramework etc, it is
better to put authorize logic for teardown into a common function
authorizeTeardown.
Diffs
-----
src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d
src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3
src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965
Diff: https://reviews.apache.org/r/40010/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/#review107804
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40010]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 24, 2015, 9:50 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40010/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 9:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3838
> https://issues.apache.org/jira/browse/MESOS-3838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mesos now have authorizeTask, authorizeFramework etc, it is
> better to put authorize logic for teardown into a common function
> authorizeTeardown.
>
>
> Diffs
> -----
>
> src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
> src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
> src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
>
> Diff: https://reviews.apache.org/r/40010/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/#review114751
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40010]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 15, 2016, 9:31 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40010/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 9:31 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3838
> https://issues.apache.org/jira/browse/MESOS-3838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Put authorize logic for teardown into a common function.
>
>
> Diffs
> -----
>
> src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d
> src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58
> src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
>
> Diff: https://reviews.apache.org/r/40010/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/
-----------------------------------------------------------
(Updated 一月 15, 2016, 9:31 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3838
https://issues.apache.org/jira/browse/MESOS-3838
Repository: mesos
Description
-------
Put authorize logic for teardown into a common function.
Diffs (updated)
-----
src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d
src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58
src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
Diff: https://reviews.apache.org/r/40010/diff/
Testing
-------
Ubuntu 14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/
-----------------------------------------------------------
(Updated 一月 15, 2016, 9:20 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3838
https://issues.apache.org/jira/browse/MESOS-3838
Repository: mesos
Description (updated)
-------
Put authorize logic for teardown into a common function.
Diffs (updated)
-----
src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d
src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58
src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422
Diff: https://reviews.apache.org/r/40010/diff/
Testing
-------
Ubuntu 14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/
-----------------------------------------------------------
(Updated 十一月 24, 2015, 9:50 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase
Bugs: MESOS-3838
https://issues.apache.org/jira/browse/MESOS-3838
Repository: mesos
Description
-------
The mesos now have authorizeTask, authorizeFramework etc, it is
better to put authorize logic for teardown into a common function
authorizeTeardown.
Diffs (updated)
-----
src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
Diff: https://reviews.apache.org/r/40010/diff/
Testing
-------
Ubuntu 14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/#review105479
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40010]
All tests passed.
- Mesos ReviewBot
On Nov. 6, 2015, 10:41 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40010/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 10:41 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3838
> https://issues.apache.org/jira/browse/MESOS-3838
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mesos now have authorizeTask, authorizeFramework etc, it is
> better to put authorize logic for teardown into a common function
> authorizeTeardown.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d
> src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3
> src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965
>
> Diff: https://reviews.apache.org/r/40010/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40010: Put authorize logic for teardown into a
common function.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/
-----------------------------------------------------------
(Updated 十一月 6, 2015, 10:41 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3838
https://issues.apache.org/jira/browse/MESOS-3838
Repository: mesos
Description
-------
The mesos now have authorizeTask, authorizeFramework etc, it is
better to put authorize logic for teardown into a common function
authorizeTeardown.
Diffs
-----
src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d
src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3
src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965
Diff: https://reviews.apache.org/r/40010/diff/
Testing (updated)
-------
Ubuntu 14.04
make
make check
Thanks,
Guangya Liu