[jira] [Closed] (BEAM-8657) Not doing Combiner lifting for data-driven triggers

["Robert Bradshaw (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Bradshaw closed BEAM-8657.
---------------------------------
    Fix Version/s: 2.18.0
       Resolution: Fixed

> Not doing Combiner lifting for data-driven triggers
> ---------------------------------------------------
>
>                 Key: BEAM-8657
>                 URL: https://issues.apache.org/jira/browse/BEAM-8657
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: wendy liu
>            Assignee: Robert Bradshaw
>            Priority: Major
>             Fix For: 2.18.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> The test below will always produce empty output, due to combiner lifting, which already combines all input values of one shard into one before grouping. To fix this, we shall not do Combiner lifting for the data-driven triggers.
> l = [window.TimestampedValue(('a', 1), 1),
>  window.TimestampedValue(('b', 3), 3),
>  window.TimestampedValue(('a', 2), 2),
>  window.TimestampedValue(('a', 5), 5),]
> result = (p | Map(lambda x : x) | 'window' >> beam.WindowInto(FixedWindows(6), trigger=trigger.AfterCount(2), accumulation_mode=trigger.AccumulationMode.DISCARDING) | beam.CombinePerKey(combine.Largest(1)))



--
This message was sent by Atlassian Jira
(v8.3.4#803005)