You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/04 06:57:32 UTC

[GitHub] [flink] lirui-apache opened a new pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

lirui-apache opened a new pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012
 
 
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Store schema of generic table as properties, so that `HiveCatalog` is able to support types that are not supported by Hive, e.g. `TIMESTAMP(!=9)`.
   
   
   ## Brief change log
   
     - Store table schema as properties when creating generic tables
     - Retrieve table schema from properties when getting generic tables
     - Add test
   
   
   ## Verifying this change
   
   Existing and new test cases.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581858128
 
 
   My personal build succeeds: https://travis-ci.org/lirui-apache/flink/builds/645851575

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] danny0405 commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581837077
 
 
   What is a 'generic table', it seems not a  jargon or terminology

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581770442
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit df658c89289171ef60b8939090fd53982ce46061 (Tue Feb 04 07:00:38 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15858).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#discussion_r374512995
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
 ##########
 @@ -587,57 +599,67 @@ protected static Table instantiateHiveTable(ObjectPath tablePath, CatalogBaseTab
 		// When creating a table, A hive table needs explicitly have a key is_generic = false
 		// otherwise, this is a generic table if 1) the key is missing 2) is_generic = true
 		// this is opposite to reading a table and instantiating a CatalogTable. See instantiateCatalogTable()
+		boolean isGeneric;
 		if (!properties.containsKey(CatalogConfig.IS_GENERIC)) {
-			// must be a generic catalog
+			// must be a generic table
+			isGeneric = true;
 			properties.put(CatalogConfig.IS_GENERIC, String.valueOf(true));
-			properties = maskFlinkProperties(properties);
 		} else {
-			boolean isGeneric = Boolean.valueOf(properties.get(CatalogConfig.IS_GENERIC));
-
-			if (isGeneric) {
-				properties = maskFlinkProperties(properties);
-			}
+			isGeneric = Boolean.parseBoolean(properties.get(CatalogConfig.IS_GENERIC));
 		}
 
-		// Table properties
-		hiveTable.setParameters(properties);
-
 		// Hive table's StorageDescriptor
 		StorageDescriptor sd = hiveTable.getSd();
 		setStorageFormat(sd, properties);
 
-		List<FieldSchema> allColumns = HiveTableUtil.createHiveColumns(table.getSchema());
-
-		// Table columns and partition keys
-		if (table instanceof CatalogTableImpl) {
-			CatalogTable catalogTable = (CatalogTableImpl) table;
-
-			if (catalogTable.isPartitioned()) {
-				int partitionKeySize = catalogTable.getPartitionKeys().size();
-				List<FieldSchema> regularColumns = allColumns.subList(0, allColumns.size() - partitionKeySize);
-				List<FieldSchema> partitionColumns = allColumns.subList(allColumns.size() - partitionKeySize, allColumns.size());
+		if (isGeneric) {
+			DescriptorProperties tableSchemaProps = new DescriptorProperties(true);
+			tableSchemaProps.putTableSchema(HiveCatalogConfig.GENERIC_TABLE_SCHEMA_PREFIX, table.getSchema());
+			properties.putAll(tableSchemaProps.asMap());
+
+			if (table instanceof CatalogTableImpl) {
+				List<String> partColNames = ((CatalogTableImpl) table).getPartitionKeys();
+				if (!partColNames.isEmpty()) {
+					properties.put(HiveCatalogConfig.GENERIC_PART_COL_NAMES, String.join(",", partColNames));
 
 Review comment:
   We don't need support partition for generic table. And this serialization maybe not right.
   We should wait https://github.com/apache/flink/pull/10059

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#discussion_r374510511
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogConfig.java
 ##########
 @@ -32,4 +32,9 @@
 
 	// Partition related configs
 	public static final String PARTITION_LOCATION = "partition.location";
+
+	// config prefix for the table schema of a generic table
+	public static final String GENERIC_TABLE_SCHEMA_PREFIX = "generic.table.schema";
 
 Review comment:
   `CatalogConfig.FLINK_PROPERTY_PREFIX` will be added to all the Flink properties. So we'll have sth like `flink.generic.table.schema.0...` and `flink.generic.table.schema.1...` in the final table properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581807221
 
 
   > Can hive's table have no fields?
   
   I thought not. But it turned out hive doesn't complain about that. So I think we're good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581769797
 
 
   cc @JingsongLi @bowenli86 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147484170 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:b04ce5c7f696686449f706ee475347cd9d5280e5 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147490226 TriggerType:PUSH TriggerID:b04ce5c7f696686449f706ee475347cd9d5280e5
   Hash:b04ce5c7f696686449f706ee475347cd9d5280e5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4847 TriggerType:PUSH TriggerID:b04ce5c7f696686449f706ee475347cd9d5280e5
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   * a0a903f95212da071f39bba248900ce6e1b3f3a2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147484170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845) 
   * b04ce5c7f696686449f706ee475347cd9d5280e5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147490226) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4847) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#discussion_r374505837
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
 ##########
 @@ -587,57 +599,67 @@ protected static Table instantiateHiveTable(ObjectPath tablePath, CatalogBaseTab
 		// When creating a table, A hive table needs explicitly have a key is_generic = false
 		// otherwise, this is a generic table if 1) the key is missing 2) is_generic = true
 		// this is opposite to reading a table and instantiating a CatalogTable. See instantiateCatalogTable()
+		boolean isGeneric;
 		if (!properties.containsKey(CatalogConfig.IS_GENERIC)) {
-			// must be a generic catalog
+			// must be a generic table
+			isGeneric = true;
 			properties.put(CatalogConfig.IS_GENERIC, String.valueOf(true));
-			properties = maskFlinkProperties(properties);
 		} else {
-			boolean isGeneric = Boolean.valueOf(properties.get(CatalogConfig.IS_GENERIC));
-
-			if (isGeneric) {
-				properties = maskFlinkProperties(properties);
-			}
+			isGeneric = Boolean.parseBoolean(properties.get(CatalogConfig.IS_GENERIC));
 		}
 
-		// Table properties
-		hiveTable.setParameters(properties);
-
 		// Hive table's StorageDescriptor
 		StorageDescriptor sd = hiveTable.getSd();
 		setStorageFormat(sd, properties);
 
-		List<FieldSchema> allColumns = HiveTableUtil.createHiveColumns(table.getSchema());
-
-		// Table columns and partition keys
-		if (table instanceof CatalogTableImpl) {
-			CatalogTable catalogTable = (CatalogTableImpl) table;
-
-			if (catalogTable.isPartitioned()) {
-				int partitionKeySize = catalogTable.getPartitionKeys().size();
-				List<FieldSchema> regularColumns = allColumns.subList(0, allColumns.size() - partitionKeySize);
-				List<FieldSchema> partitionColumns = allColumns.subList(allColumns.size() - partitionKeySize, allColumns.size());
+		if (isGeneric) {
+			DescriptorProperties tableSchemaProps = new DescriptorProperties(true);
+			tableSchemaProps.putTableSchema(HiveCatalogConfig.GENERIC_TABLE_SCHEMA_PREFIX, table.getSchema());
+			properties.putAll(tableSchemaProps.asMap());
+
+			if (table instanceof CatalogTableImpl) {
+				List<String> partColNames = ((CatalogTableImpl) table).getPartitionKeys();
+				if (!partColNames.isEmpty()) {
+					properties.put(HiveCatalogConfig.GENERIC_PART_COL_NAMES, String.join(",", partColNames));
 
 Review comment:
   For compatibility issue, should throw exception now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581806752
 
 
   PR updated to disallow creating partitioned generic table with HiveCatalog.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-582260425
 
 
   I don't think the python failure is related. It has been failing for several other PRs lately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#discussion_r374545696
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
 ##########
 @@ -587,57 +599,67 @@ protected static Table instantiateHiveTable(ObjectPath tablePath, CatalogBaseTab
 		// When creating a table, A hive table needs explicitly have a key is_generic = false
 		// otherwise, this is a generic table if 1) the key is missing 2) is_generic = true
 		// this is opposite to reading a table and instantiating a CatalogTable. See instantiateCatalogTable()
+		boolean isGeneric;
 		if (!properties.containsKey(CatalogConfig.IS_GENERIC)) {
-			// must be a generic catalog
+			// must be a generic table
+			isGeneric = true;
 			properties.put(CatalogConfig.IS_GENERIC, String.valueOf(true));
-			properties = maskFlinkProperties(properties);
 		} else {
-			boolean isGeneric = Boolean.valueOf(properties.get(CatalogConfig.IS_GENERIC));
-
-			if (isGeneric) {
-				properties = maskFlinkProperties(properties);
-			}
+			isGeneric = Boolean.parseBoolean(properties.get(CatalogConfig.IS_GENERIC));
 		}
 
-		// Table properties
-		hiveTable.setParameters(properties);
-
 		// Hive table's StorageDescriptor
 		StorageDescriptor sd = hiveTable.getSd();
 		setStorageFormat(sd, properties);
 
-		List<FieldSchema> allColumns = HiveTableUtil.createHiveColumns(table.getSchema());
-
-		// Table columns and partition keys
-		if (table instanceof CatalogTableImpl) {
-			CatalogTable catalogTable = (CatalogTableImpl) table;
-
-			if (catalogTable.isPartitioned()) {
-				int partitionKeySize = catalogTable.getPartitionKeys().size();
-				List<FieldSchema> regularColumns = allColumns.subList(0, allColumns.size() - partitionKeySize);
-				List<FieldSchema> partitionColumns = allColumns.subList(allColumns.size() - partitionKeySize, allColumns.size());
+		if (isGeneric) {
+			DescriptorProperties tableSchemaProps = new DescriptorProperties(true);
+			tableSchemaProps.putTableSchema(HiveCatalogConfig.GENERIC_TABLE_SCHEMA_PREFIX, table.getSchema());
+			properties.putAll(tableSchemaProps.asMap());
+
+			if (table instanceof CatalogTableImpl) {
+				List<String> partColNames = ((CatalogTableImpl) table).getPartitionKeys();
+				if (!partColNames.isEmpty()) {
+					properties.put(HiveCatalogConfig.GENERIC_PART_COL_NAMES, String.join(",", partColNames));
 
 Review comment:
   OK I'll create another JIRA to track that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung merged pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
KurtYoung merged pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581857627
 
 
   > What is a 'generic table', it seems not a jargon or terminology
   
   HiveCatalog can handle two kinds of tables: hive-compatible tables and generic tables. For the former, we store the metadata in a hive-compatible way so that Hive itself can access those tables. For the latter, we just use HMS as a storage to persist the metadata, and Hive won't be able to (and doesn't need to) understand that metadata. I guess the latter one is `generic` from HMS's point of view.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   * a0a903f95212da071f39bba248900ce6e1b3f3a2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-582232259
 
 
   please see my comments in the jira

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147484170 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   * a0a903f95212da071f39bba248900ce6e1b3f3a2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147484170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#discussion_r374506163
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogConfig.java
 ##########
 @@ -32,4 +32,9 @@
 
 	// Partition related configs
 	public static final String PARTITION_LOCATION = "partition.location";
+
+	// config prefix for the table schema of a generic table
+	public static final String GENERIC_TABLE_SCHEMA_PREFIX = "generic.table.schema";
 
 Review comment:
   consistent with `CatalogConfig.FLINK_PROPERTY_PREFIX`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581777662
 
 
   Can hive's table have no fields?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147484170 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:b04ce5c7f696686449f706ee475347cd9d5280e5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147490226 TriggerType:PUSH TriggerID:b04ce5c7f696686449f706ee475347cd9d5280e5
   Hash:b04ce5c7f696686449f706ee475347cd9d5280e5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4847 TriggerType:PUSH TriggerID:b04ce5c7f696686449f706ee475347cd9d5280e5
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   * a0a903f95212da071f39bba248900ce6e1b3f3a2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147484170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845) 
   * b04ce5c7f696686449f706ee475347cd9d5280e5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147490226) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4847) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] danny0405 commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581865727
 
 
   > > What is a 'generic table', it seems not a jargon or terminology
   > 
   > HiveCatalog can handle two kinds of tables: hive-compatible tables and generic tables. For the former, we store the metadata in a hive-compatible way so that Hive itself can access those tables. For the latter, we just use HMS as a storage to persist the metadata, and Hive won't be able to (and doesn't need to) understand that metadata. I guess the latter one is `generic` from HMS's point of view.
   
   Thanks for the explanation !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147345452 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812 TriggerType:PUSH TriggerID:ec67bb7cabd8f8c8cb705b6ea17c955a786da16f
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147484170 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:a0a903f95212da071f39bba248900ce6e1b3f3a2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845 TriggerType:PUSH TriggerID:a0a903f95212da071f39bba248900ce6e1b3f3a2
   Hash:b04ce5c7f696686449f706ee475347cd9d5280e5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b04ce5c7f696686449f706ee475347cd9d5280e5
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   * ec67bb7cabd8f8c8cb705b6ea17c955a786da16f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147345452) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4812) 
   * a0a903f95212da071f39bba248900ce6e1b3f3a2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147484170) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4845) 
   * b04ce5c7f696686449f706ee475347cd9d5280e5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11012: [FLINK-15858][hive] Store generic table schema as properties
URL: https://github.com/apache/flink/pull/11012#issuecomment-581778343
 
 
   <!--
   Meta data
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147331379 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   Hash:df658c89289171ef60b8939090fd53982ce46061 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810 TriggerType:PUSH TriggerID:df658c89289171ef60b8939090fd53982ce46061
   -->
   ## CI report:
   
   * df658c89289171ef60b8939090fd53982ce46061 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147331379) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4810) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services