[kudu-CR] [NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager

["David Ribeiro Alves (Code Review)" <ge...@cloudera.org>]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5240

to look at the new patch set (#2).

Change subject: [NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager
......................................................................

[NOT FOR REVIEW] KUDU-798 (part 3) Remove the clock from MvccManager

All mvcc transactions are now started at a timestamp so there is no
need for MvccManager to assign timestamps. Without this there
was a single place where we used the clock, outside of checks:
We used the clock in WaitForCleanSnapshotAtTimestamp() to make sure
the clock was past the timestamp before waiting on the snapshot to
be clean.

While this didn't make much sense, since the clean timestamp
shouldn't ever move past the current clock value, this is currently
a proxy to waiting for "safe time" on leader side transactions.
Until we properly handle that in follow up patches this check was
moved to where we handle snapshot scans in TabletService.

Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tablet/transactions/write_transaction.h
M src/kudu/tserver/tablet_service.cc
12 files changed, 86 insertions(+), 106 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/5240/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>