You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2026/02/20 13:33:28 UTC
[PR] Fixes hashicorp-vault test running localy. Relates to #7543 [camel-quarkus]
JiriOndrusek opened a new pull request, #8325:
URL: https://github.com/apache/camel-quarkus/pull/8325
Workaround for https://github.com/apache/camel-quarkus/issues/7543
When hashicorp test runs on the system, which contains this module's /target/classes folder, test fails.
Reason is explained in the ticket https://github.com/apache/camel-quarkus/issues/7543
Artifact created by this module does not contain anything (except license) in the target/classes folder.
Workaround loads and installs the licences from the different folder (target/license) and therefore does not trigger the Quarkus classloader.
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes hashicorp-vault test running localy. Relates to #7543 [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #8325:
URL: https://github.com/apache/camel-quarkus/pull/8325#issuecomment-3934686012
@jamesnetherton I think that https://github.com/apache/camel-quarkus/issues/7543 can bbe closed, but follow-up ticket can be nice (to solve the problem "cleanly" - this is more like a workaround)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes (with workaround) hashicorp-vault test running localy. Relates to #7543 [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #8325:
URL: https://github.com/apache/camel-quarkus/pull/8325#discussion_r2839592926
##########
extensions-support/spring/shade/core/pom.xml:
##########
@@ -82,6 +82,35 @@
</execution>
</executions>
</plugin>
+ <!-- Workaround for https://github.com/apache/camel-quarkus/issues/7543
+ See more information in th ticket.
+ Shortly, when hashicorp test runs onb the system, which contains this module/target/classes, it fails.
+ Reason is explained in the ticker https://github.com/apache/camel-quarkus/issues/7543
+ Artifact created by this module does mot contain anything (except license) in the target/classes folder.
+ Workaround loads and installs the licences from the folder target/license
+ -->
Review Comment:
```suggestion
<!--
Workaround for https://github.com/apache/camel-quarkus/issues/7543.
This module produces an artifact that does not include any compiled classes only license files, which causes tests to fail when the empty target/classes directory is detected.
The workaround explicitly loads and installs the license files from the target/license directory.
-->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes (with workaround) hashicorp-vault test running localy. Relates to #7543 [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #8325:
URL: https://github.com/apache/camel-quarkus/pull/8325#discussion_r2839680053
##########
extensions-support/spring/shade/core/pom.xml:
##########
@@ -82,6 +82,35 @@
</execution>
</executions>
</plugin>
+ <!-- Workaround for https://github.com/apache/camel-quarkus/issues/7543
+ See more information in th ticket.
+ Shortly, when hashicorp test runs onb the system, which contains this module/target/classes, it fails.
+ Reason is explained in the ticker https://github.com/apache/camel-quarkus/issues/7543
+ Artifact created by this module does mot contain anything (except license) in the target/classes folder.
+ Workaround loads and installs the licences from the folder target/license
+ -->
Review Comment:
Thanks for the rewording my comment! It's fixed in the PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes (with workaround) hashicorp-vault test running localy. Relates to #7543 [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #8325:
URL: https://github.com/apache/camel-quarkus/pull/8325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org