Re: [PR] Reset buffer aggregators when resetting Groupers. (druid)

["rohangarg (via GitHub)" <gi...@apache.org>]

rohangarg commented on code in PR #16296:
URL: https://github.com/apache/druid/pull/16296#discussion_r1572235336


##########
processing/src/main/java/org/apache/druid/query/aggregation/BufferAggregator.java:
##########
@@ -158,7 +158,9 @@ default double getDouble(ByteBuffer buf, int position)
   }
 
   /**
-   * Release any resources used by the aggregator
+   * Release any resources used by the aggregator. The aggregator may be reused after this call. This call would be

Review Comment:
   Should we state this change in release notes, incase somebody is doing a proper `close` behavior in their custom aggregator? 
   Also, what would be the correct thing to do if an aggregator has meaningful and different behaviours for both reset and close call? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org