You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/17 12:01:37 UTC

[GitHub] [geode-native] albertogpz opened a new pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

albertogpz opened a new pull request #695:
URL: https://github.com/apache/geode-native/pull/695


   Hangs in integration-test cases have been fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-728902724


   This pull request **introduces 1 alert** and **fixes 2** when merging f9bc1fdcc649764f58265ca15730b68eaf820e9e into a771a1ec215c81556126534a46abe41480658d64 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-d47f91198551bc836b8a9e0711f142dbc6bfe5e9)
   
   **new alerts:**
   
   * 1 for Wrong type of arguments to formatting function
   
   **fixed alerts:**
   
   * 2 for Comparison result is always the same


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] codecov-io commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-731896366


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=h1) Report
   > Merging [#695](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=desc) (fcf95b3) into [develop](https://codecov.io/gh/apache/geode-native/commit/9fdb183e146b0e0ecf5beed5aef87f7673f459fd?el=desc) (9fdb183) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/695/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #695      +/-   ##
   ===========================================
   + Coverage    74.04%   74.08%   +0.03%     
   ===========================================
     Files          644      644              
     Lines        51095    51095              
   ===========================================
   + Hits         37834    37853      +19     
   + Misses       13261    13242      -19     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cppcache/src/TcpConn.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcENvbm4uY3Bw) | `83.58% <0.00%> (-0.75%)` | :arrow_down: |
   | [cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=) | `62.24% <0.00%> (-0.46%)` | :arrow_down: |
   | [cppcache/src/TcrMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1Rjck1lc3NhZ2UuY3Bw) | `85.72% <0.00%> (+0.10%)` | :arrow_up: |
   | [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `73.58% <0.00%> (+0.31%)` | :arrow_up: |
   | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `75.93% <0.00%> (+0.62%)` | :arrow_up: |
   | [cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==) | `76.59% <0.00%> (+1.06%)` | :arrow_up: |
   | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `56.24% <0.00%> (+1.12%)` | :arrow_up: |
   | [...tegration-test/testThinClientRemoteRegionQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVJlZ2lvblF1ZXJ5LmNwcA==) | `83.45% <0.00%> (+1.12%)` | :arrow_up: |
   | [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/695/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `93.19% <0.00%> (+1.36%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=footer). Last update [9fdb183...181595a](https://codecov.io/gh/apache/geode-native/pull/695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mreddington commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
mreddington commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-745475960


   Should we abandon this now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-728941653


   This pull request **fixes 2 alerts** when merging 26f265372c4411d521c67cd739ec669c7c17887b into a771a1ec215c81556126534a46abe41480658d64 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-bfa5f5c41ecdc37bc740698886ff65cf4f12ac9e)
   
   **fixed alerts:**
   
   * 2 for Comparison result is always the same


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] pivotal-jbarrett closed pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett closed pull request #695:
URL: https://github.com/apache/geode-native/pull/695


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] albertogpz commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-745477125


   > Should we abandon this now?
   
   Yes, we should. The commit that was just merged contained all the fixes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-732152283


   This pull request **fixes 2 alerts** when merging 48ab63ecdf563713e45a6ad33c3bed561436d2f6 into fcf95b32773783e86976e34c0ccfc9987fa63fec - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-7c61ec45de34bc651f8ea1fbbfa9b583c7077bd5)
   
   **fixed alerts:**
   
   * 2 for Comparison result is always the same


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-730630356


   This pull request **fixes 2 alerts** when merging f3b2994e1bb4c7a30437f522c301f2a8e192620b into 0f4a3be938d466c1b559d4129cb95b372d47e68a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-e7fe42462150170e4e2c452162658bd02e2bf8f6)
   
   **fixed alerts:**
   
   * 2 for Comparison result is always the same


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-734189373


   This pull request **fixes 2 alerts** when merging 5a38e048b4a8cbb856e927fc2cae389087564e8a into fcf95b32773783e86976e34c0ccfc9987fa63fec - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-0be7cb1a2a8c8ac9ced5eebfc47bcc17719ec75a)
   
   **fixed alerts:**
   
   * 2 for Comparison result is always the same


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #695: GEODE-8318: Threading issues when switching from ACE to boost::asio

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #695:
URL: https://github.com/apache/geode-native/pull/695#issuecomment-731017541


   This pull request **fixes 2 alerts** when merging 181595a7b03e936e27c405deca598b0fc7b6de09 into fcf95b32773783e86976e34c0ccfc9987fa63fec - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-ad2cf8953743a67188ac2ef0f628cc06f3487d42)
   
   **fixed alerts:**
   
   * 2 for Comparison result is always the same


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org