[jira] [Resolved] (HTTPCLIENT-1893) Inspecting the Redirect inside a RedirectStrategy mutates the RedirectLocations array

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1893.
-------------------------------------------
    Resolution: Fixed

I moved {{HttpContext}} state logic out of {{DefaultRedirectStrategy}} to the redirect execution interceptors. {{DefaultRedirectStrategy}} no longer mutates the state of {{HttpContext}} passed as a parameter to its methods.

Please review and close.

Oleg

> Inspecting the Redirect inside a RedirectStrategy mutates the RedirectLocations array
> -------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1893
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1893
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.4
>            Reporter: Raymond Huang
>            Assignee: Oleg Kalnichevski
>             Fix For: 5.0 Beta1
>
>
> We're implementing a custom RedirectStrategy based on DefaultRedirectStrategy. We found that calling {{getLocationURI}} mutates the RedirectLocations object. 
> This seems unexpected that a {{get}} method mutates an object. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org