You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/27 13:41:55 UTC
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7443: arch/sparc: add initial support for S698PM chip and SMP
acassis commented on code in PR #7443:
URL: https://github.com/apache/incubator-nuttx/pull/7443#discussion_r1006889597
##########
arch/sparc/Kconfig:
##########
@@ -32,6 +32,19 @@ config ARCH_CHIP_BM3823
---help---
Microchip BM3823 (ARCH_SPARC_V8)
+config ARCH_CHIP_S698PM
+ bool "S698PM"
+ select ARCH_SPARC_V8
+ select ARCH_HAVE_MATH_H
+ select ARCH_HAVE_IRQPRIO
+ select ARCH_VECNOTIRQ
+ select ARCH_HAVE_RAMFUNCS
+ select ARCH_HAVE_MULTICPU
+ select ARCH_HAVE_TESTSET
+ select ARCH_HAVE_SERIAL_TERMIOS
+ ---help---
+ Microchip S698PM (ARCH_SPARC_V8)
Review Comment:
```suggestion
ORBITA Sailing S698PM (ARCH_SPARC_V8)
##########
arch/sparc/Kconfig:
##########
@@ -32,6 +32,19 @@ config ARCH_CHIP_BM3823
---help---
Microchip BM3823 (ARCH_SPARC_V8)
+config ARCH_CHIP_S698PM
+ bool "S698PM"
+ select ARCH_SPARC_V8
+ select ARCH_HAVE_MATH_H
+ select ARCH_HAVE_IRQPRIO
+ select ARCH_VECNOTIRQ
+ select ARCH_HAVE_RAMFUNCS
+ select ARCH_HAVE_MULTICPU
+ select ARCH_HAVE_TESTSET
+ select ARCH_HAVE_SERIAL_TERMIOS
+ ---help---
+ Microchip S698PM (ARCH_SPARC_V8)
Review Comment:
Using Microchip (to indicate chip) could make people think that Microchip company created it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org