You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/02 12:05:29 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #887: [GA] Daily publish snapshot
pan3793 opened a new pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-890984670
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@c6bee7c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2fb679e differs from pull request most recent head 5b2044a. Consider uploading reports for the commit 5b2044a to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #887 +/- ##
=========================================
Coverage ? 78.77%
Complexity ? 11
=========================================
Files ? 137
Lines ? 5196
Branches ? 644
=========================================
Hits ? 4093
Misses ? 749
Partials ? 354
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6bee7c...5b2044a](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-891061689
we may add other protocol support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r680976847
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
> not need to specify `-Papache-release`?
There is no GPG info in GA, I'm planing use `-Papache-release` in RC release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r680973827
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
Review comment:
Yes, plan to cut `branch-1.3` soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r681014422
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
Review comment:
Make sense, I'm going to switch all image to `ubuntu-20.04`. BTW, Apache Spark mix uses `ubuntu-20.04` and `ubuntu-latest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-891063193
> we may add other protocol support
got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r681016581
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
I’AM OK to publish it as long as the snapshot has nothing to do with final releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-891530088
Thanks for reviewing. I'm going to merge it. Then will send a following PR to add `_2.12` suffix in Scala modules and also enable `-Pkyuubi-extension-spark-3-1` in daily snapshot publish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-890984670
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@c6bee7c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #887 +/- ##
=========================================
Coverage ? 78.77%
Complexity ? 11
=========================================
Files ? 137
Lines ? 5196
Branches ? 644
=========================================
Hits ? 4093
Misses ? 749
Partials ? 354
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6bee7c...5b2044a](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r680976034
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
> `-Pkyuubi-extension-spark-3-1` ?
@yaooqinn Should we publish `kyuubi-extension-spark-3-1` to maven central ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r681022751
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
Just realized that Spark 3.2 will support both Scala 2.12 and 2.13. But `kyuubi-extension-spark-3-1` only build against Scala 2.12, and the package name lack the `_2.12` suffix, it may confuse users who want to use it with Spark 3.2. (I guess only few users will run Spark 3.2 with Scala 2.13 in production?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r681015612
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r681007091
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
Review comment:
shall we use the latest LTS？
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
shall we rm all the kyuubi artifacts from cache？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-891035314
BTW, what do you think of renaming `kyuubi-hive-jdbc` to `kyuubi-jdbc`? @yaooqinn @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r680923992
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
Review comment:
do we need `branch-1.3` snapshot ?
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
not need to specify `-Papache-release` ?
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
`-Pkyuubi-extension-spark-3-1` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#issuecomment-890984670
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@c6bee7c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2fb679e differs from pull request most recent head f29cb6e. Consider uploading reports for the commit f29cb6e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #887 +/- ##
=========================================
Coverage ? 78.77%
Complexity ? 11
=========================================
Files ? 137
Lines ? 5196
Branches ? 644
=========================================
Hits ? 4093
Misses ? 749
Partials ? 354
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6bee7c...f29cb6e](https://codecov.io/gh/apache/incubator-kyuubi/pull/887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #887: [GA] Daily publish snapshot
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #887:
URL: https://github.com/apache/incubator-kyuubi/pull/887#discussion_r681363784
##########
File path: .github/workflows/publish-snapshot.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Snapshot
+
+on:
+ schedule:
+ - cron: '0 0 * * *'
+
+jobs:
+ publish-snapshot:
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ branch:
+ - master
+ - branch-1.3
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@master
+ with:
+ ref: ${{ matrix.branch }}
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ snapshot-maven-
+ - name: Install Java 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Publish snapshot
+ env:
+ ASF_USERNAME: ${{ secrets.NEXUS_USER }}
+ ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
+ run: ./build/mvn clean deploy -DskipTests -Pspark-provided -s ./build/release/asf-settings.xml
Review comment:
> There is no GPG info in GA, I'm planing use -Papache-release in RC release.
ah I see, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org