You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/24 07:59:37 UTC
[GitHub] [inlong] xxhannah opened a new pull request, #6622: [INLONG-6620][Sort] Support metadata for Kafka Source
xxhannah opened a new pull request, #6622:
URL: https://github.com/apache/inlong/pull/6622
### Prepare a Pull Request
- Title: [INLONG-6620][Sort] Support metadata for Kafka Source
- Fixes #6620
### Motivation
Support Kafka metadata for Kafka source connector
### Modifications
Add metadata : key, value, headers(json string) to Kafka connector.
Add Kafka meta field to sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6622: [INLONG-6620][Sort] Support metadata for Kafka source
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6622:
URL: https://github.com/apache/inlong/pull/6622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #6622: [INLONG-6620][Sort] Support metadata for Kafka source
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #6622:
URL: https://github.com/apache/inlong/pull/6622#issuecomment-1327621649
@xxhannah please rebase and push again to fix the failed UT, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] xxhannah commented on a diff in pull request #6622: [INLONG-6620][Sort] Support metadata for Kafka source
Posted by GitBox <gi...@apache.org>.
xxhannah commented on code in PR #6622:
URL: https://github.com/apache/inlong/pull/6622#discussion_r1033077603
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaDynamicSource.java:
##########
@@ -18,6 +18,9 @@
package org.apache.inlong.sort.kafka.table;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
Review Comment:
OK~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #6622: [INLONG-6620][Sort] Support metadata for Kafka source
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #6622:
URL: https://github.com/apache/inlong/pull/6622#discussion_r1032562784
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaDynamicSource.java:
##########
@@ -18,6 +18,9 @@
package org.apache.inlong.sort.kafka.table;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
Review Comment:
change to
```
import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonProcessingException;
import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org