You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2023/08/03 08:34:36 UTC
[GitHub] [iotdb] HTHou opened a new pull request, #10766: [IOTDB-6098] Fix a possible flush error when using aligned timeseries
HTHou opened a new pull request, #10766:
URL: https://github.com/apache/iotdb/pull/10766
## Description

To reproduce, set `max_number_of_points_in_page = 2`.
Then execute the following sqls:
```sql
insert into root.sg.d1(time, s1,s2) aligned values(1,'aa','bb')
insert into root.sg.d1(time, s1,s2) aligned values(1,'aa','bb')
insert into root.sg.d1(time, s1,s2) aligned values(1,'aa','bb')
flush
```
The reason of this bug is the time page may be empty, we do not need to update the statistics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #10766: [IOTDB-6098] Fix a possible flush error when using aligned timeseries
Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #10766:
URL: https://github.com/apache/iotdb/pull/10766#issuecomment-1663624233
[](https://coveralls.io/builds/61758234)
coverage: 48.016% (-0.009%) from 48.025% when pulling **9f78734ed94016724f9e5b79b2ede9f3c57b1d9c on iotdb_6098** into **e9b9b63a95719c14c674258d92eabf36a0bb69d1 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #10766: [IOTDB-6098] Fix a possible flush error when using aligned timeseries
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #10766:
URL: https://github.com/apache/iotdb/pull/10766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #10766: [IOTDB-6098] Fix a possible flush error when using aligned timeseries
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10766:
URL: https://github.com/apache/iotdb/pull/10766#issuecomment-1663549555
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=10766)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=10766&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=10766&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=10766&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=10766&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10766&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10766&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10766&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=10766&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org