You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/03/01 15:01:22 UTC

Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Testing manually ok.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL Certificate)
on CloudStack 4.0.1

Changes include:
(1) update realhostip.keystore in SSVM (see change of config_ssl.sh)
(2) change suffix of download iso/template url to domain_suffix in SSL Certificate.


This addresses bug CLOUD-1475.


Diffs
-----

  agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
  console-proxy/scripts/config_ssl.sh 8d80c47 
  core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
  core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
  server/src/com/cloud/configuration/Config.java dbcc97a 
  server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
  server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
  server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
  server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
  server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 

Diff: https://reviews.apache.org/r/9696/diff/


Testing
-------

Testing manually ok.


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Jayapal Reddy <ja...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review20678
-----------------------------------------------------------


Changes are looking fine.
Nithin can you also please review the changes.
 

- Jayapal Reddy


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request 9696: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review23014
-----------------------------------------------------------


Commit 521dcbdcc087515a67ad467f6c4b39f63c9390bc in branch refs/heads/master from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=521dcbd ]

CLOUDSTACK-1475: fix RegisterISO error after Update SSL Certificate


- ASF Subversion and Git Services


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-1475
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request 9696: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review23070
-----------------------------------------------------------


Commit 3b5bcac81a14aa239e172f14f1819bd445063a6a in branch refs/heads/4.1 from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3b5bcac ]

CLOUDSTACK-1475: fix RegisterISO error after Update SSL Certificate


- ASF Subversion and Git Services


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-1475
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request 9696: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review23069
-----------------------------------------------------------


Commit b2a077dfff5ba71723187ce970a4aa040794fe82 in branch refs/heads/4.2 from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b2a077d ]

CLOUDSTACK-1475: fix RegisterISO error after Update SSL Certificate


- ASF Subversion and Git Services


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Jayapal Reddy and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-1475
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Animesh Chaturvedi <An...@citrix.com>.


> On May 17, 2013, 5:18 a.m., Nitin Mehta wrote:
> > Ship It!

Nitin can you commit the patch


- Animesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review20681
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Chip Childers <ch...@sungard.com>.

On Fri, May 17, 2013 at 06:24:21AM +0000, Wei Zhou wrote:
> 
> 
> > On May 17, 2013, 5:18 a.m., Nitin Mehta wrote:
> > > Ship It!
> > 
> > Animesh Chaturvedi wrote:
> >     Nitin can you commit the patch
> > 
> > Nitin Mehta wrote:
> >     Some files seem to be removed or atleast the location has changed. Needs to rebased. Wei - can you please take a look and commit it ?
> >
> 
> ok. I will.

I didn't think anyone was planning on releasing out of the 4.0 branch
again...  so is this needed?

> 
> 
> - Wei
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/#review20681
> -----------------------------------------------------------
> 
> 
> On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9696/
> > -----------------------------------------------------------
> > 
> > (Updated March 15, 2013, 9:54 a.m.)
> > 
> > 
> > Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> > 
> > 
> > Description
> > -------
> > 
> > This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> > on CloudStack 4.0.1. 
> > 
> > 
> > Changes include:
> > (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> > (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> > (3) validate download URL because ssvm publicip or domain suffix may change.
> > 
> > 
> > This addresses bug CLOUDSTACK-1475.
> > 
> > 
> > Diffs
> > -----
> > 
> >   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
> >   console-proxy/scripts/config_ssl.sh 8d80c47 
> >   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
> >   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
> >   server/src/com/cloud/configuration/Config.java dbcc97a 
> >   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
> >   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
> >   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
> >   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
> >   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
> >   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> > 
> > Diff: https://reviews.apache.org/r/9696/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Testing manually ok.
> > 
> > 
> > To test:
> > (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> > http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> > 
> > (2) visit instance via console. 
> > 
> > (3) Download ISO/Template. The browser will show the download url.
> > Before patch: the domain suffix of url always be "realhostip.com"
> > after patch: the domain suffix of url is "company.com" which you set in step(1).
> > 
> > (4) Register ISO/Template using the url in step(3).
> > Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> > after patch: successful.
> > 
> > (5) Destroy SSVM, and a new one will be created. 
> > Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> > after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> > 
> > (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> > aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> > 
> > 
> > We need to restart management-server after Update SSL Certificate.
> > 
> > 
> > Thanks,
> > 
> > Wei Zhou
> > 
> >
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.


> On May 17, 2013, 5:18 a.m., Nitin Mehta wrote:
> > Ship It!
> 
> Animesh Chaturvedi wrote:
>     Nitin can you commit the patch
> 
> Nitin Mehta wrote:
>     Some files seem to be removed or atleast the location has changed. Needs to rebased. Wei - can you please take a look and commit it ?
>

ok. I will.


- Wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review20681
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Nitin Mehta <ni...@citrix.com>.


> On May 17, 2013, 5:18 a.m., Nitin Mehta wrote:
> > Ship It!
> 
> Animesh Chaturvedi wrote:
>     Nitin can you commit the patch

Some files seem to be removed or atleast the location has changed. Needs to rebased. Wei - can you please take a look and commit it ?


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review20681
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Nitin Mehta <ni...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review20681
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/
-----------------------------------------------------------

(Updated March 15, 2013, 9:54 a.m.)

Review request for cloudstack, Nitin Mehta and Jayapal Reddy.

Description (updated)
-------

This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
on CloudStack 4.0.1.

Changes include:
(1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
(2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
(3) validate download URL because ssvm publicip or domain suffix may change.

This addresses bug CLOUDSTACK-1475.

Diffs
-----

agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079
console-proxy/scripts/config_ssl.sh 8d80c47
core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca
core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d
server/src/com/cloud/configuration/Config.java dbcc97a
server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720
server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780
server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c
server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b
server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777
server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8

Diff: https://reviews.apache.org/r/9696/diff/

Testing (updated)
-------

Testing manually ok.

To test:
(1) generate update the SSL certificate and it. see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf

(2) visit instance via console.

(3) Download ISO/Template. The browser will show the download url.
Before patch: the domain suffix of url always be "realhostip.com"
after patch: the domain suffix of url is "company.com" which you set in step(1).

(4) Register ISO/Template using the url in step(3).
Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
after patch: successful.

(5) Destroy SSVM, and a new one will be created.
Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.

(6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.

We need to restart management-server after Update SSL Certificate.

Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Nitin Mehta <ni...@citrix.com>.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 120
> > <https://reviews.apache.org/r/9696/diff/2/?file=264869#file264869line120>
> >
> >     are there any dependencies on this flag in the code ?
> >     We need to remove this flag during migration as well.
> 
> Wei Zhou wrote:
>     consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.
> 
> Nitin Mehta wrote:
>     But if someone is upgrading to this version s/he will have this entry in the DB and hence in the global setting correct ? Can you please put a delete statement so that people upgrading do not get confused by this entry ? You can look into the upgrade files for example
> 
> Wei Zhou wrote:
>     Of course. At first I would like to ensure the fixed version (4.0.2/4.1.0/master), then I willcreate an patch including the removement.

I hope you will open a bug for this and fix it


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review17961
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > Can you please also tell me a list of tests done for this ?

Nitin, I add a list of tests in "Testing Done" part. Please have a look.

consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.

I can define a new constant in SecondaryStorageVmManager which is same to ConsoleProxyManager.CERTIFICATE_NAME, but I think it is not necessary.

The list "token" is the result I split the download url of ISO/Template by "/". For example, url is https://10-11-101-112.realhostip.com/userdata/2fdd9a70-9c4a-4a04-b1d5-1e41c221a1f9.iso. the token[2] is 10-11-101-112.realhostip.com. 


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 120
> > <https://reviews.apache.org/r/9696/diff/2/?file=264869#file264869line120>
> >
> >     are there any dependencies on this flag in the code ?
> >     We need to remove this flag during migration as well.

consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/download/DownloadMonitorImpl.java, line 202
> > <https://reviews.apache.org/r/9696/diff/2/?file=264874#file264874line202>
> >
> >     can you please use SecondaryStorageVmManager instead ?

I can define a new constant in SecondaryStorageVmManager which is same to ConsoleProxyManager.CERTIFICATE_NAME, but I think it is not necessary.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/upload/UploadMonitorImpl.java, line 225
> > <https://reviews.apache.org/r/9696/diff/2/?file=264875#file264875line225>
> >
> >     can you put an example here...seems some hardcoding

The list "token" is the result I split the download url of ISO/Template by "/". For example, url is https://10-11-101-112.realhostip.com/userdata/2fdd9a70-9c4a-4a04-b1d5-1e41c221a1f9.iso. the token[2] is 10-11-101-112.realhostip.com. 


- Wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review17961
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Nitin Mehta <ni...@citrix.com>.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > Can you please also tell me a list of tests done for this ?
> 
> Wei Zhou wrote:
>     Nitin, I add a list of tests in "Testing Done" part. Please have a look.
>     
>     consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.
>     
>     I can define a new constant in SecondaryStorageVmManager which is same to ConsoleProxyManager.CERTIFICATE_NAME, but I think it is not necessary.
>     
>     The list "token" is the result I split the download url of ISO/Template by "/". For example, url is https://10-11-101-112.realhostip.com/userdata/2fdd9a70-9c4a-4a04-b1d5-1e41c221a1f9.iso. the token[2] is 10-11-101-112.realhostip.com.

Wei - Really appreciate your hard work on this. Thanks for submitting the patch and writing in the detailed test cases, really makes it crystal clear to understand.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/upload/UploadMonitorImpl.java, line 225
> > <https://reviews.apache.org/r/9696/diff/2/?file=264875#file264875line225>
> >
> >     can you put an example here...seems some hardcoding
> 
> Wei Zhou wrote:
>     The list "token" is the result I split the download url of ISO/Template by "/". For example, url is https://10-11-101-112.realhostip.com/userdata/2fdd9a70-9c4a-4a04-b1d5-1e41c221a1f9.iso. the token[2] is 10-11-101-112.realhostip.com.

Wei - Can you please put this as a comment in the code please - this would greatly help devs to understand in the future ?


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/download/DownloadMonitorImpl.java, line 202
> > <https://reviews.apache.org/r/9696/diff/2/?file=264874#file264874line202>
> >
> >     can you please use SecondaryStorageVmManager instead ?
> 
> Wei Zhou wrote:
>     I can define a new constant in SecondaryStorageVmManager which is same to ConsoleProxyManager.CERTIFICATE_NAME, but I think it is not necessary.

I would rather put it in SecondaryStorageVmManager so that other devs are not confused and the design is more modularized and maintainable.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 120
> > <https://reviews.apache.org/r/9696/diff/2/?file=264869#file264869line120>
> >
> >     are there any dependencies on this flag in the code ?
> >     We need to remove this flag during migration as well.
> 
> Wei Zhou wrote:
>     consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.

But if someone is upgrading to this version s/he will have this entry in the DB and hence in the global setting correct ? Can you please put a delete statement so that people upgrading do not get confused by this entry ? You can look into the upgrade files for example


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review17961
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 120
> > <https://reviews.apache.org/r/9696/diff/2/?file=264869#file264869line120>
> >
> >     are there any dependencies on this flag in the code ?
> >     We need to remove this flag during migration as well.
> 
> Wei Zhou wrote:
>     consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.
> 
> Nitin Mehta wrote:
>     But if someone is upgrading to this version s/he will have this entry in the DB and hence in the global setting correct ? Can you please put a delete statement so that people upgrading do not get confused by this entry ? You can look into the upgrade files for example
> 
> Wei Zhou wrote:
>     Of course. At first I would like to ensure the fixed version (4.0.2/4.1.0/master), then I willcreate an patch including the removement.
> 
> Nitin Mehta wrote:
>     I hope you will open a bug for this and fix it

Nitin,
This patch is for 4.0.X only. I will create an patch for master branch if the bug still exists.


- Wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review17961
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/download/DownloadMonitorImpl.java, line 202
> > <https://reviews.apache.org/r/9696/diff/2/?file=264874#file264874line202>
> >
> >     can you please use SecondaryStorageVmManager instead ?
> 
> Wei Zhou wrote:
>     I can define a new constant in SecondaryStorageVmManager which is same to ConsoleProxyManager.CERTIFICATE_NAME, but I think it is not necessary.
> 
> Nitin Mehta wrote:
>     I would rather put it in SecondaryStorageVmManager so that other devs are not confused and the design is more modularized and maintainable.

CPVM and SSVM use the same SSL certificate with name = ConsoleProxyManager.CERTIFICATE_NAME = "CPVMCertificate".
ConsoleProxyManager.CERTIFICATE_NAME is also used in com.cloud.storage.secondary.SecondaryStorageManagerImpl.generateSetupCommand(Long).
To compatible with lower version of cloudstack, it is difficult to change the certificate name.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 120
> > <https://reviews.apache.org/r/9696/diff/2/?file=264869#file264869line120>
> >
> >     are there any dependencies on this flag in the code ?
> >     We need to remove this flag during migration as well.
> 
> Wei Zhou wrote:
>     consoleproxy.url.domain is not used in any source codes. We use "company.com" which is set in SSL certificate update as the domain suffix of console url.
> 
> Nitin Mehta wrote:
>     But if someone is upgrading to this version s/he will have this entry in the DB and hence in the global setting correct ? Can you please put a delete statement so that people upgrading do not get confused by this entry ? You can look into the upgrade files for example

Of course. At first I would like to ensure the fixed version (4.0.2/4.1.0/master), then I willcreate an patch including the removement.


> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/upload/UploadMonitorImpl.java, line 225
> > <https://reviews.apache.org/r/9696/diff/2/?file=264875#file264875line225>
> >
> >     can you put an example here...seems some hardcoding
> 
> Wei Zhou wrote:
>     The list "token" is the result I split the download url of ISO/Template by "/". For example, url is https://10-11-101-112.realhostip.com/userdata/2fdd9a70-9c4a-4a04-b1d5-1e41c221a1f9.iso. the token[2] is 10-11-101-112.realhostip.com.
> 
> Nitin Mehta wrote:
>     Wei - Can you please put this as a comment in the code please - this would greatly help devs to understand in the future ?

Of course.


- Wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review17961
-----------------------------------------------------------


On March 15, 2013, 9:54 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 9:54 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUDSTACK-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUDSTACK-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> To test:
> (1) generate update the SSL certificate and it.  see "17.3.1. Changing the Console Proxy SSL Certificate and Domain" part in CloudPlatform3.0.6AdminGuide
> http://support.citrix.com/servlet/KbServlet/download/33425-102-696517/CloudPlatform3.0.6AdminGuide.pdf
> 
> (2) visit instance via console. 
> 
> (3) Download ISO/Template. The browser will show the download url.
> Before patch: the domain suffix of url always be "realhostip.com"
> after patch: the domain suffix of url is "company.com" which you set in step(1).
> 
> (4) Register ISO/Template using the url in step(3).
> Before patch: When the domain suffix is not "realhostip.com", it fails with error message "sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".
> after patch: successful.
> 
> (5) Destroy SSVM, and a new one will be created. 
> Before patch: the url in step(3) does not change. the url still be the ip address of old SSVM, and old domain suffix.
> after patch: the url will contain the ip address of new SSVM. If the "company.com" changes, the url will also contain the new domain suffix.
> 
> (6) If you do not have a DNS server (which can resolve company.com domain), please add an entry in /etc/hosts file of the client.
> aaa-bbb-ccc-ddd aaa-bbb-ccc-ddd.company.com        # aaa.bbb.ccc.ddd is the console proxy ip. and ssvm as well.
> 
> 
> We need to restart management-server after Update SSL Certificate.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Nitin Mehta <ni...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/#review17961
-----------------------------------------------------------


Can you please also tell me a list of tests done for this ?


server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/9696/#comment37964>

    are there any dependencies on this flag in the code ?
    We need to remove this flag during migration as well.



server/src/com/cloud/storage/download/DownloadMonitorImpl.java
<https://reviews.apache.org/r/9696/#comment37962>

    can you please use SecondaryStorageVmManager instead ?



server/src/com/cloud/storage/upload/UploadMonitorImpl.java
<https://reviews.apache.org/r/9696/#comment37963>

    can you put an example here...seems some hardcoding


- Nitin Mehta


On March 6, 2013, 10:06 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 10:06 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL Certificate)
> on CloudStack 4.0.1. 
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may change.
> 
> 
> This addresses bug CLOUD-1475.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
>   console-proxy/scripts/config_ssl.sh 8d80c47 
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
>   server/src/com/cloud/configuration/Config.java dbcc97a 
>   server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
>   server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> We need to restart management-server after Update SSL Certificate
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

RE: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Animesh Chaturvedi <an...@citrix.com>.

Nitin, Jayaal

Please review and apply the patch if satisfied

Animesh

> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Wednesday, March 06, 2013 2:06 AM
> To: Jayapal Reddy Uradi; Nitin Mehta
> Cc: cloudstack; Prasanna Santhanam; Wei Zhou
> Subject: Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM
> and change download iso/template url after Update SSL Certificate
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9696/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 10:06 a.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Jayapal Reddy.
> 
> 
> Changes
> -------
> 
> Can you guys help review this? The patch is for 4.0.1 but should be applicable
> for master too
> 
> 
> Description
> -------
> 
> This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL
> Certificate) on CloudStack 4.0.1.
> 
> 
> Changes include:
> (1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
> (2) change suffix of download iso/template url rom realhostip.com to
> domain_suffix in SSL Certificate.
> (3) validate download URL because ssvm publicip or domain suffix may
> change.
> 
> 
> This addresses bug CLOUD-1475.
> 
> 
> Diffs
> -----
> 
> 
> agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.
> java 48f5079
>   console-proxy/scripts/config_ssl.sh 8d80c47
>   core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java
> c606fca
>   core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java
> 155210d
>   server/src/com/cloud/configuration/Config.java dbcc97a
> 
> server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java
> 01b4720
> 
> server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyM
> anager.java 6172780
>   server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java
> d2df83c
>   server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java
> 2736777
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8
> 
> Diff: https://reviews.apache.org/r/9696/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> We need to restart management-server after Update SSL Certificate
> 
> 
> Thanks,
> 
> Wei Zhou

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Prasanna Santhanam <Pr...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/
-----------------------------------------------------------

(Updated March 6, 2013, 10:06 a.m.)


Review request for cloudstack, Nitin Mehta and Jayapal Reddy.


Changes
-------

Can you guys help review this? The patch is for 4.0.1 but should be applicable for master too


Description
-------

This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL Certificate)
on CloudStack 4.0.1. 


Changes include:
(1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
(2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
(3) validate download URL because ssvm publicip or domain suffix may change.


This addresses bug CLOUD-1475.


Diffs
-----

  agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
  console-proxy/scripts/config_ssl.sh 8d80c47 
  core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
  core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
  server/src/com/cloud/configuration/Config.java dbcc97a 
  server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
  server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
  server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
  server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
  server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 

Diff: https://reviews.apache.org/r/9696/diff/


Testing
-------

Testing manually ok.

We need to restart management-server after Update SSL Certificate


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/
-----------------------------------------------------------

(Updated March 4, 2013, 12:11 p.m.)


Review request for cloudstack.


Changes
-------

 validate download URL because ssvm publicip or domain suffix may change.


Description (updated)
-------

This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL Certificate)
on CloudStack 4.0.1. 


Changes include:
(1) update realhostip.keystore in SSVM (see the change in config_ssl.sh)
(2) change suffix of download iso/template url rom realhostip.com to domain_suffix in SSL Certificate.
(3) validate download URL because ssvm publicip or domain suffix may change.


This addresses bug CLOUD-1475.


Diffs (updated)
-----

  agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
  console-proxy/scripts/config_ssl.sh 8d80c47 
  core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
  core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
  server/src/com/cloud/configuration/Config.java dbcc97a 
  server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
  server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
  server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
  server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
  server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 

Diff: https://reviews.apache.org/r/9696/diff/


Testing (updated)
-------

Testing manually ok.

We need to restart management-server after Update SSL Certificate


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

Posted by Wei Zhou <w....@leaseweb.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9696/
-----------------------------------------------------------

(Updated March 1, 2013, 2:01 p.m.)


Review request for cloudstack.


Summary (updated)
-----------------

(CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate


Description
-------

This patch is for issue CLOUD-1475 (RegisterISO error after Update SSL Certificate)
on CloudStack 4.0.1

Changes include:
(1) update realhostip.keystore in SSVM (see change of config_ssl.sh)
(2) change suffix of download iso/template url to domain_suffix in SSL Certificate.


This addresses bug CLOUD-1475.


Diffs
-----

  agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 48f5079 
  console-proxy/scripts/config_ssl.sh 8d80c47 
  core/src/com/cloud/storage/resource/CifsSecondaryStorageResource.java c606fca 
  core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java 155210d 
  server/src/com/cloud/configuration/Config.java dbcc97a 
  server/src/com/cloud/consoleproxy/AgentBasedConsoleProxyManager.java 01b4720 
  server/src/com/cloud/consoleproxy/AgentBasedStandaloneConsoleProxyManager.java 6172780 
  server/src/com/cloud/consoleproxy/StaticConsoleProxyManager.java d2df83c 
  server/src/com/cloud/server/ConfigurationServerImpl.java 3368c9b 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java 2736777 
  server/src/com/cloud/storage/upload/UploadMonitorImpl.java 4231be8 

Diff: https://reviews.apache.org/r/9696/diff/


Testing
-------

Testing manually ok.


Thanks,

Wei Zhou