You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2019/11/29 20:15:00 UTC
[jira] [Updated] (COLLECTIONS-737) The test FluentIterableTest.size
should be split
[ https://issues.apache.org/jira/browse/COLLECTIONS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory updated COLLECTIONS-737:
----------------------------------------
Summary: The test FluentIterableTest.size should be split (was: The test FluentIterableTest.size should be splitted)
> The test FluentIterableTest.size should be split
> ------------------------------------------------
>
> Key: COLLECTIONS-737
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-737
> Project: Commons Collections
> Issue Type: Test
> Components: Collection
> Reporter: Pengyu Nie
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The first part of FluentIterableTest.size is not testing function
> FluentIterable.size (see code copied below). Actually,
> FluentIterable.size will not be invoked at all, because
> FluentIterable.of(null) will throw an NPE before that. This part
> should be extracted as a separate unit test like
> FluentIterableTest.ofNull.
> {code:java}
> try {
> FluentIterable.of((Iterable<?>) null).size();
> fail("expecting NullPointerException");
> } catch (final NullPointerException npe) {
> // expected
> }{code}
> I'll create a pull request for this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)