[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #268: nginx connection configurage to values.yaml attribute

[GitBox <gi...@apache.org>]

tokers commented on code in PR #268:
URL: https://github.com/apache/apisix-helm-chart/pull/268#discussion_r871183026


##########
charts/apisix/values.yaml:
##########
@@ -312,6 +312,21 @@ logs:
   errorLog: "/dev/stderr"
   errorLogLevel: "warn"
 
+# access and error log configuration
+nginx:
+  core:
+    worker_rlimit_nofile: 20480
+    events:
+      worker_connections: 10620
+  logs:
+    enableAccessLog: true

Review Comment:
   I think we need to change all the places that we use the log parameters.



##########
charts/apisix/README.md:
##########
@@ -201,6 +201,20 @@ discovery:
 | `logs.errorLog`                  | Error log path | `/dev/stderr` |
 | `logs.errorLogLevel`                  | Error log level | `warn` |

Review Comment:
   Mark these parameters as deprecated. We can remove them after a few releases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org