[GitHub] [dubbo] guohao commented on a change in pull request #8774: [3.0-Triple] use promise catch server send big header exception

[GitBox <gi...@apache.org>]

guohao commented on a change in pull request #8774:
URL: https://github.com/apache/dubbo/pull/8774#discussion_r706960528



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2FrameServerHandler.java
##########
@@ -199,10 +200,18 @@ public void onHeadersRead(ChannelHandlerContext ctx, Http2HeadersFrame msg) thro
         } else {
             stream = AbstractServerStream.unary(invoker.getUrl());
         }
+        ctx.channel().attr(TripleUtil.SERVER_STREAM_KEY).set(stream);
+        Channel channel = ctx.channel();
+        ChannelPromise promise = channel.newPromise();
+        promise.addListener(future -> {

Review comment:
       This exception should be throwed to RPC caller




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org