[GitHub] [tomcat] lkirchev commented on issue #252: 8.5.x

[GitBox <gi...@apache.org>]

lkirchev commented on issue #252: 8.5.x
URL: https://github.com/apache/tomcat/pull/252#issuecomment-607765082
 
 
   Thanks a lot Mark! Yes, you are right, I overlooked the dependency I introduced. I added another commit with a proposal for replacing o.a.c.c.Request with HttpServletRequest. 
   Only to mention that in the TestCookieProcessorGeneration the usage of the newly introduced dummy implementation of HttpServletRequest could be replace just with nulls - this reference is never used in the two implementations of CookieProcessor in Tomcat. 
   However, I didn't like very much the idea to use nulls, that's why I introduced the dummy implementation.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org