You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/10 08:01:32 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7072: UI: fix diskofferingstrictness is not passed when create compute offering
weizhouapache opened a new pull request, #7072:
URL: https://github.com/apache/cloudstack/pull/7072
### Description
This PR fixes #7070
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7072: UI: fix diskofferingstrictness is not passed when create compute offering
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7072:
URL: https://github.com/apache/cloudstack/pull/7072#issuecomment-1377029119
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7072](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (518ee5a) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/5b9a989ab0dd6b8f482f4d6c6ce24e1a6108002e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b9a989) will **increase** coverage by `0.00%`.
> The diff coverage is `41.30%`.
```diff
@@ Coverage Diff @@
## 4.17 #7072 +/- ##
=========================================
Coverage 10.36% 10.37%
- Complexity 6635 6644 +9
=========================================
Files 2453 2453
Lines 242385 242406 +21
Branches 37927 37932 +5
=========================================
+ Hits 25134 25146 +12
- Misses 214147 214152 +5
- Partials 3104 3108 +4
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../main/java/com/cloud/network/NetworkModelImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvTmV0d29ya01vZGVsSW1wbC5qYXZh) | `9.92% <0.00%> (ø)` | |
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `15.74% <16.66%> (-0.25%)` | :arrow_down: |
| [...in/java/com/cloud/server/ManagementServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | `3.08% <45.45%> (+0.57%)` | :arrow_up: |
| [...in/java/com/cloud/host/dao/HostDetailsDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L2Rhby9Ib3N0RGV0YWlsc0Rhb0ltcGwuamF2YQ==) | `20.68% <50.00%> (+3.38%)` | :arrow_up: |
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `61.94% <0.00%> (-0.36%)` | :arrow_down: |
| [...ema/src/main/java/com/cloud/vm/UserVmDetailVO.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9Vc2VyVm1EZXRhaWxWTy5qYXZh) | `55.55% <0.00%> (+5.55%)` | :arrow_up: |
| [.../schema/src/main/java/com/cloud/host/DetailVO.java](https://codecov.io/gh/apache/cloudstack/pull/7072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L0RldGFpbFZPLmphdmE=) | `69.23% <0.00%> (+53.84%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7072: UI: fix diskofferingstrictness is not passed when create compute offering
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7072:
URL: https://github.com/apache/cloudstack/pull/7072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7072: UI: fix diskofferingstrictness is not passed when create compute offering
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7072:
URL: https://github.com/apache/cloudstack/pull/7072#discussion_r1065779435
##########
ui/public/locales/en.json:
##########
@@ -1977,6 +1977,7 @@
"label.rootdisk": "ROOT disk",
"label.rootdiskcontrollertype": "Root disk controller",
"label.rootdiskcontrollertypekvm": "Root disk controller",
+"label.rootdisksize": "Root disk size (GB)",
Review Comment:
Is this change relevant to the issue at hand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7072: UI: fix diskofferingstrictness is not passed when create compute offering
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7072:
URL: https://github.com/apache/cloudstack/pull/7072#issuecomment-1378800745
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7072: UI: fix diskofferingstrictness is not passed when create compute offering
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7072:
URL: https://github.com/apache/cloudstack/pull/7072#issuecomment-1378985074
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #7072: UI: fix diskofferingstrictness is not passed when create compute offering
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #7072:
URL: https://github.com/apache/cloudstack/pull/7072#discussion_r1068063679
##########
ui/public/locales/en.json:
##########
@@ -1977,6 +1977,7 @@
"label.rootdisk": "ROOT disk",
"label.rootdiskcontrollertype": "Root disk controller",
"label.rootdiskcontrollertypekvm": "Root disk controller",
+"label.rootdisksize": "Root disk size (GB)",
Review Comment:
Its not relevant, but fixes another small issue in service offering listing along with this.
<img width="342" alt="image" src="https://user-images.githubusercontent.com/3348673/212066478-d786c9db-634d-4a2e-8950-d67b268a4bd5.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org