[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29819: [SPARK-27428][CORE][TEST] Increase receive buffer size used in StatsdSinkSuite

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29819:
URL: https://github.com/apache/spark/pull/29819#discussion_r497979070



##########
File path: core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala
##########
@@ -35,12 +35,27 @@ class StatsdSinkSuite extends SparkFunSuite {
     STATSD_KEY_UNIT -> "seconds",
     STATSD_KEY_HOST -> "127.0.0.1"
   )
-  private val socketTimeout = 30000 // milliseconds
-  private val socketBufferSize = 8192
+  // The maximum size of a single datagram packet payload. Payloads
+  // larger than this will be truncated.
+  private val maxPayloadSize = 256 // bytes
+
+  // The receive buffer must be large enough to hold all inflight
+  // packets. This includes any kernel and protocol overhead.
+  // This value was determined experimentally and should be
+  // increased if timeouts are seen.
+  private val socketMinRecvBufferSize = 16384 // bytes
+  private val socketTimeout = 30000           // milliseconds

Review comment:
       Please move this to the original position to reduce the unnecessary diff and don't add space between `30000` and `// milliseconds`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org