[GitHub] [beam] brachipa commented on a change in pull request #15915: [beam-12737] add API to handle failed rows in the collection due to sql query runtime error

[GitBox <gi...@apache.org>]

brachipa commented on a change in pull request #15915:
URL: https://github.com/apache/beam/pull/15915#discussion_r746354961



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -112,11 +119,19 @@
   private static final long MILLIS_PER_DAY = 86400000L;
 
   private static final ParameterExpression rowParam = Expressions.parameter(Row.class, "row");
+  private PTransform<PCollection<BeamCalcRelError>, POutput> errorsTransformer;
+  private static final TupleTag<Row> rows = new TupleTag<Row>() {};
+  private static final TupleTag<BeamCalcRelError> errors = new TupleTag<BeamCalcRelError>() {};
 
   public BeamCalcRel(RelOptCluster cluster, RelTraitSet traits, RelNode input, RexProgram program) {
     super(cluster, traits, input, program);
   }
 
+  @Override
+  public void withErrorsTransformer(PTransform<PCollection<BeamCalcRelError>, POutput> ptransform) {

Review comment:
       Yes, I can add to `buildPTransform`, but it will break the API for all `BeamRelNode` implementations. 
   When I add it with a default function, any implementation  that don't need to handle errors can continue as it was before, and the one that want to do error handling will implement this method and use this variable. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org