You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/01/11 14:14:09 UTC
Re: Review Request 41875: Removed List type which is not needed
anymore with C++11.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41875/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 2:14 p.m.)
Review request for mesos, Ben Mahler and Till Toenshoff.
Changes
-------
Removed not needed type List as std::list is now good enough (cf. #17029).
Summary (updated)
-----------------
Removed List type which is not needed anymore with C++11.
Bugs: MESOS-4273
https://issues.apache.org/jira/browse/MESOS-4273
Repository: mesos
Description (updated)
-------
This type was added to provide a variadic constructor around a
std::list. Now that C++11 is used this is not needed anymore as we can
directly invoke std::list's constructor taking a std::initializer_list.
Review: https://reviews.apache.org/r/41875
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe
3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 864d8c9498d66f14ab6fc531965c12fb397b5fe5
Diff: https://reviews.apache.org/r/41875/diff/
Testing
-------
make check (OS X 10.10.5 and Debian 8)
Thanks,
Benjamin Bannier
Re: Review Request 41875: Removed List type which is not needed
anymore with C++11.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41875/#review113995
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Jan. 11, 2016, 2:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41875/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 2:14 p.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-4273
> https://issues.apache.org/jira/browse/MESOS-4273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This type was added to provide a variadic constructor around a
> std::list. Now that C++11 is used this is not needed anymore as we can
> directly invoke std::list's constructor taking a std::initializer_list.
>
> Review: https://reviews.apache.org/r/41875
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe
> 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 864d8c9498d66f14ab6fc531965c12fb397b5fe5
>
> Diff: https://reviews.apache.org/r/41875/diff/
>
>
> Testing
> -------
>
> make check (OS X 10.10.5 and Debian 8)
>
>
> Thanks,
>
> Benjamin Bannier
>
>