You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Jarek Cecho <ja...@apache.org> on 2012/07/10 09:54:37 UTC

Review Request: FLUME-1360: Provide documentation for static interceptor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/
-----------------------------------------------------------

Review request for Flume.


Description
-------

I've documented static interceptor and I also put some examples to other interceptors as well.


This addresses bug FLUME-1360.
    https://issues.apache.org/jira/browse/FLUME-1360


Diffs
-----

  /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1359503 

Diff: https://reviews.apache.org/r/5879/diff/


Testing
-------


Thanks,

Jarek Cecho

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Jarek Cecho <ja...@apache.org>.

> On July 16, 2012, 4:31 p.m., Patrick Wendell wrote:
> > /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1694
> > <https://reviews.apache.org/r/5879/diff/1/?file=121198#file121198line1694>
> >
> >     This comma should be removed.

All other tables with properties do contains this comma, so I let it be (to be consistent).


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/#review9173
-----------------------------------------------------------


On July 16, 2012, 4:53 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5879/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 4:53 p.m.)
> 
> 
> Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.
> 
> 
> Description
> -------
> 
> I've documented static interceptor and I also put some examples to other interceptors as well.
> 
> 
> This addresses bug FLUME-1360.
>     https://issues.apache.org/jira/browse/FLUME-1360
> 
> 
> Diffs
> -----
> 
>   /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1362119 
> 
> Diff: https://reviews.apache.org/r/5879/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Patrick Wendell <pw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/#review9173
-----------------------------------------------------------


Looked over the static interceptor. Some grammar issues are noted. Overall, the documentation correctly conforms to the implementation.


/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5879/#comment19633>

    "to append static header" --> "to append a static header"



/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5879/#comment19634>

    --> "The current implementation does not..."



/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5879/#comment19636>

    This comma should be removed.


- Patrick Wendell


On July 13, 2012, 1:57 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5879/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 1:57 p.m.)
> 
> 
> Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.
> 
> 
> Description
> -------
> 
> I've documented static interceptor and I also put some examples to other interceptors as well.
> 
> 
> This addresses bug FLUME-1360.
>     https://issues.apache.org/jira/browse/FLUME-1360
> 
> 
> Diffs
> -----
> 
>   /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1359503 
> 
> Diff: https://reviews.apache.org/r/5879/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Jarek Cecho <ja...@apache.org>.

> On July 19, 2012, 5:51 a.m., Hari Shreedharan wrote:
> > +1. Thanks for the patch, Jarcec! Please attach the patch to the jira.

Hi Hari,
thank you very much for your review, I've attached last patch version to the jira.

Jarcec


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/#review9275
-----------------------------------------------------------


On July 16, 2012, 4:53 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5879/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 4:53 p.m.)
> 
> 
> Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.
> 
> 
> Description
> -------
> 
> I've documented static interceptor and I also put some examples to other interceptors as well.
> 
> 
> This addresses bug FLUME-1360.
>     https://issues.apache.org/jira/browse/FLUME-1360
> 
> 
> Diffs
> -----
> 
>   /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1362119 
> 
> Diff: https://reviews.apache.org/r/5879/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/#review9275
-----------------------------------------------------------

Ship it!


+1. Thanks for the patch, Jarcec! Please attach the patch to the jira.

- Hari Shreedharan


On July 16, 2012, 4:53 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5879/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 4:53 p.m.)
> 
> 
> Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.
> 
> 
> Description
> -------
> 
> I've documented static interceptor and I also put some examples to other interceptors as well.
> 
> 
> This addresses bug FLUME-1360.
>     https://issues.apache.org/jira/browse/FLUME-1360
> 
> 
> Diffs
> -----
> 
>   /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1362119 
> 
> Diff: https://reviews.apache.org/r/5879/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/
-----------------------------------------------------------

(Updated July 16, 2012, 4:53 p.m.)


Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.


Changes
-------

Hi Patrik,
thank you very much for you feedback. I've fixed grammar issues that you've pointed out.

Jarcec


Description
-------

I've documented static interceptor and I also put some examples to other interceptors as well.


This addresses bug FLUME-1360.
    https://issues.apache.org/jira/browse/FLUME-1360


Diffs (updated)
-----

  /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1362119 

Diff: https://reviews.apache.org/r/5879/diff/


Testing
-------


Thanks,

Jarek Cecho

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/
-----------------------------------------------------------

(Updated July 13, 2012, 1:57 p.m.)


Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.


Description
-------

I've documented static interceptor and I also put some examples to other interceptors as well.


This addresses bug FLUME-1360.
    https://issues.apache.org/jira/browse/FLUME-1360


Diffs
-----

  /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1359503 

Diff: https://reviews.apache.org/r/5879/diff/


Testing
-------


Thanks,

Jarek Cecho

Re: Review Request: FLUME-1360: Provide documentation for static interceptor

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/
-----------------------------------------------------------

(Updated July 12, 2012, 5:56 a.m.)


Review request for Flume, Juhani Connolly, Mike Percy, and Hari Shreedharan.


Description
-------

I've documented static interceptor and I also put some examples to other interceptors as well.


This addresses bug FLUME-1360.
    https://issues.apache.org/jira/browse/FLUME-1360


Diffs
-----

  /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1359503 

Diff: https://reviews.apache.org/r/5879/diff/


Testing
-------


Thanks,

Jarek Cecho