You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/24 00:28:51 UTC

[GitHub] [zookeeper] hanm commented on a change in pull request #1511: ZOOKEEPER-3981: Flaky test MultipleAddressTest::testGetValidAddressWithNotValid

hanm commented on a change in pull request #1511:
URL: https://github.com/apache/zookeeper/pull/1511#discussion_r511211195



##########
File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/MultipleAddressesTest.java
##########
@@ -110,7 +110,7 @@ public void testGetValidAddress() throws NoRouteToHostException {
     @Test
     public void testGetValidAddressWithNotValid() {
         assertThrows(NoRouteToHostException.class, () -> {
-            MultipleAddresses multipleAddresses = new MultipleAddresses(new InetSocketAddress("10.0.0.1", 22));
+            MultipleAddresses multipleAddresses = new MultipleAddresses(new InetSocketAddress("240.0.0.0", 22));

Review comment:
       I agree this is a better choice, so applied the suggestion. Love the github feature of commit in place (and thanks for the suggestion!)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org