You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2025/10/19 00:08:45 UTC
[PR] Add support for jdk17 and jdk21 and add these jdks to CI [fluss]
snuyanzin opened a new pull request, #1836:
URL: https://github.com/apache/fluss/pull/1836
### Purpose
Add support for jdk17, 21 and also add them to ci in order to be sure it is able to build and pass tests
### Brief change log
1. it would make sense to bump both to the latest versions where jdk11 is still supported
1.25.0 - first googleJavaFormat where jdk11 was dropped (for more details https://github.com/google/google-java-format/releases?page=1)
2.xx.x - jdk11 is still supported
3.0.0 is the first was it was dropped (for more details https://github.com/diffplug/spotless/releases?page=1)
### Brief change log
2. Move spotless plugin to java11+ profile. The reason for that is that newer spotless requires java11 runtime, which means property like `skip.on.java8` will not help (not sure, may be completely remove this property?)
3. Adjust extra `add-exports`
4. Add jdks to ci
### Tests
existing + with newer jdks
### API and Format
no
### Documentation
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [build] Add support for jdk17 and jdk21 and add these jdks to CI [fluss]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #1836:
URL: https://github.com/apache/fluss/pull/1836#issuecomment-3456585047
fyi: @wuchong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [build] Add support for jdk17 and jdk21 and add these jdks to CI [fluss]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #1836:
URL: https://github.com/apache/fluss/pull/1836#discussion_r2442694266
##########
.github/workflows/ci.yaml:
##########
@@ -54,4 +54,16 @@ jobs:
name: "Java 11"
uses: ./.github/workflows/ci-template.yaml
with:
- java-version: "11"
\ No newline at end of file
+ java-version: "11"
+
+ build-on-jdk17:
+ name: "Java 17"
+ uses: ./.github/workflows/ci-template.yaml
+ with:
+ java-version: "17"
+
+ build-on-jdk21:
+ name: "Java 21"
+ uses: ./.github/workflows/ci-template.yaml
+ with:
+ java-version: "21"
Review Comment:
or test only on one jdk, and only build for others?
Tests for every jdk may be move to nightly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org