You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Vikas Kumar <ta...@gmail.com> on 2024/12/20 12:20:33 UTC

Review Request 75319: RANGER-5035 : kms module: update for code readability improvement

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75319/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Madhan Neethiraj, and Sailaja Polavarapu.


Repository: ranger


Description
-------

Formatted KMS code to comply with Ranger code checkstyle rules.

Found around 169 violations that has been fixed.
This change contains only code formatting changes except few where I had to make minor changes.


Diffs
-----

  kms/pom.xml 510ddb111 
  kms/src/main/java/javax/ws/rs/core/NoContentException.java b9366122d 
  kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 7bce126ce 
  kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java f07a1fea8 
  kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java aec8eaeec 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java 39de0a503 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java 2740e4529 
  kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 0cf832fd3 
  kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java be369c95f 
  kms/src/main/java/org/apache/hadoop/crypto/key/KeySecureToRangerDBMKUtil.java 7fafa1052 
  kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java d3b717a8a 
  kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 2998baa3c 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 2fa5c02f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAzureKeyVaultKeyGenerator.java 138a897bd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java a61cabb1b 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 90ef729b2 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java d5cdf18cd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java b09cd5bad 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 39b5d65d1 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 957d2ca0e 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java db3750ecc 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 444092f34 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 4cad1e5d8 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 632e728f4 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java e5ebeb783 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java 675a357f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 1fe7e25d6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java e65577c98 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLsType.java 388cdd7ae 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 31f66384f 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuditLogger.java 8ae2ea3d9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ed37df634 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSConfiguration.java 29f4a7d39 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b5be765e6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJMXServlet.java 6918015a9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONReader.java 59cc21823 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java a4e2b3042 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b975bd099 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java f1dca05fb 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSServerJSONUtils.java f4814865d 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java f7330a8b4 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java 8bcc6db5c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/MetricREST.java f91902d1c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/RangerKMSRestApi.java 04d26f7e7 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java c787806e2 
  kms/src/main/java/org/apache/ranger/common/RangerJsonProvider.java cd5ad385a 
  kms/src/main/java/org/apache/ranger/entity/XXDBBase.java cced013a1 
  kms/src/main/java/org/apache/ranger/entity/XXRangerKeyStore.java 093cf5640 
  kms/src/main/java/org/apache/ranger/entity/XXRangerMasterKey.java e0f147b85 
  kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 8b0f74eac 
  kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java 9e4d0bd89 
  kms/src/main/java/org/apache/ranger/kms/dao/DaoManagerBase.java a5b4fe8a3 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerKMSDao.java 11a131f64 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerMasterKeyDao.java 93fc9fb11 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetricWrapper.java 1ff299242 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetrics.java 9c5bd3b9e 
  kms/src/main/java/org/apache/ranger/kms/metrics/collector/KMSMetricsCollector.java 87391f3ea 
  kms/src/main/java/org/apache/ranger/kms/metrics/source/KMSMetricSource.java 600e206e0 
  kms/src/main/resources/hadoop-metrics2.properties df4d7eada 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java 16b374b51 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java 072c7f9f8 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java f89971876 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java a86ea02ce 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSACLs.java 03eaee82a 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 4e0b4ff80 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java 874232832 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java 3b74e3e71 
  kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java 4609d1e1e 
  kms/src/test/resources/hadoop-metrics2.properties f3897ba0b 


Diff: https://reviews.apache.org/r/75319/diff/1/


Testing
-------

Project build (mvn clean install) was successful.
ALL UTs passed.


Thanks,

Vikas Kumar

Re: Review Request 75319: RANGER-5035 : kms module: update for code readability improvement

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75319/#review227140
-----------------------------------------------------------




kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java
Line 184 (original), 184 (patched)
<https://reviews.apache.org/r/75319/#comment315414>

    With parameterized log calls, logger.isDebugEnabled() aren't needed. Please review and remove them, unless parameters are expensive to compute.



kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java
Line 39 (original), 40 (patched)
<https://reviews.apache.org/r/75319/#comment315415>

    I suggest separating static and non-static members with an empty line:
    
        private static final String AZURE_CLIENT_ID                 = "ranger.kms.azure.client.id";
        private static final String AZURE_CLIENT_SECRET             = "ranger.kms.azure.client.secret";
        private static final String AZURE_MASTER_KEY_ALIAS          = "ranger.kms.azure.masterkey.name";
        private static final String AZURE_KEYVAULT_CERTIFICATE_PATH = "ranger.kms.azure.keyvault.certificate.path";
        private static final String AZURE_KEYVAULT_URL              = "ranger.kms.azurekeyvault.url";
        private static final String ENCRYPTION_KEY                  = "ranger.db.encrypt.key.password";
        private static final String AZURE_MASTER_KEY_TYPE           = "ranger.kms.azure.masterkey.type";
        private static final String ZONE_KEY_ENCRYPTION_ALGO        = "ranger.kms.azure.zonekey.encryption.algorithm";
    
        private RangerKeyStore dbStore;



kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java
Line 50 (original), 47 (patched)
<https://reviews.apache.org/r/75319/#comment315416>

    To be consistent with rest of the code base, please have Logger declaration as the first line in the class.


- Madhan Neethiraj


On Dec. 20, 2024, 12:20 p.m., Vikas Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75319/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2024, 12:20 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Madhan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Formatted KMS code to comply with Ranger code checkstyle rules.
> 
> Found around 169 violations that has been fixed.
> This change contains only code formatting changes except few where I had to make minor changes.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml 510ddb111 
>   kms/src/main/java/javax/ws/rs/core/NoContentException.java b9366122d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 7bce126ce 
>   kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java f07a1fea8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java aec8eaeec 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java 39de0a503 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java 2740e4529 
>   kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 0cf832fd3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java be369c95f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/KeySecureToRangerDBMKUtil.java 7fafa1052 
>   kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java d3b717a8a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 2998baa3c 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 2fa5c02f8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerAzureKeyVaultKeyGenerator.java 138a897bd 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java a61cabb1b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 90ef729b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java d5cdf18cd 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java b09cd5bad 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 39b5d65d1 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 957d2ca0e 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java db3750ecc 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 444092f34 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 4cad1e5d8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 632e728f4 
>   kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java e5ebeb783 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java 675a357f8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 1fe7e25d6 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java e65577c98 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLsType.java 388cdd7ae 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 31f66384f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuditLogger.java 8ae2ea3d9 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ed37df634 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSConfiguration.java 29f4a7d39 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b5be765e6 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJMXServlet.java 6918015a9 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONReader.java 59cc21823 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java a4e2b3042 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b975bd099 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java f1dca05fb 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSServerJSONUtils.java f4814865d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java f7330a8b4 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java 8bcc6db5c 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/MetricREST.java f91902d1c 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/RangerKMSRestApi.java 04d26f7e7 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java c787806e2 
>   kms/src/main/java/org/apache/ranger/common/RangerJsonProvider.java cd5ad385a 
>   kms/src/main/java/org/apache/ranger/entity/XXDBBase.java cced013a1 
>   kms/src/main/java/org/apache/ranger/entity/XXRangerKeyStore.java 093cf5640 
>   kms/src/main/java/org/apache/ranger/entity/XXRangerMasterKey.java e0f147b85 
>   kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 8b0f74eac 
>   kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java 9e4d0bd89 
>   kms/src/main/java/org/apache/ranger/kms/dao/DaoManagerBase.java a5b4fe8a3 
>   kms/src/main/java/org/apache/ranger/kms/dao/RangerKMSDao.java 11a131f64 
>   kms/src/main/java/org/apache/ranger/kms/dao/RangerMasterKeyDao.java 93fc9fb11 
>   kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetricWrapper.java 1ff299242 
>   kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetrics.java 9c5bd3b9e 
>   kms/src/main/java/org/apache/ranger/kms/metrics/collector/KMSMetricsCollector.java 87391f3ea 
>   kms/src/main/java/org/apache/ranger/kms/metrics/source/KMSMetricSource.java 600e206e0 
>   kms/src/main/resources/hadoop-metrics2.properties df4d7eada 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java 16b374b51 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java 072c7f9f8 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java f89971876 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java a86ea02ce 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSACLs.java 03eaee82a 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 4e0b4ff80 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java 874232832 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java 3b74e3e71 
>   kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java 4609d1e1e 
>   kms/src/test/resources/hadoop-metrics2.properties f3897ba0b 
> 
> 
> Diff: https://reviews.apache.org/r/75319/diff/1/
> 
> 
> Testing
> -------
> 
> Project build (mvn clean install) was successful.
> ALL UTs passed.
> 
> 
> Thanks,
> 
> Vikas Kumar
> 
>

Re: Review Request 75319: RANGER-5035 : kms module: update for code readability improvement

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75319/#review227139
-----------------------------------------------------------




kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java
Line 34 (original), 33 (patched)
<https://reviews.apache.org/r/75319/#comment315410>

    I suggest to not break a statement into multiple lines, to keep within 80 character length. Keep a single line per statement - to improve readability.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java
Line 68 (original), 70 (patched)
<https://reviews.apache.org/r/75319/#comment315411>

    Update lines 70, 71 and 85 for whitespace alignment with following lines.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java
Line 124 (original), 153 (patched)
<https://reviews.apache.org/r/75319/#comment315412>

    Avoid unnecessary line breaks like:
    - #153 & #154
    - #160 & #161
    - #171 & #172
    - #173 & 174
    - ...
    
    Please review other such occurrences and join these lines - to make them easier to read.



kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java
Line 133 (original), 162 (patched)
<https://reviews.apache.org/r/75319/#comment315413>

    I suggest to replace string concat with parameterized message:
    
      log.info("  KMS Hadoop Version: {}", VersionInfo.getVersion());
    
    Please review other occurrences and update.


- Madhan Neethiraj


On Dec. 20, 2024, 12:20 p.m., Vikas Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75319/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2024, 12:20 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Madhan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Formatted KMS code to comply with Ranger code checkstyle rules.
> 
> Found around 169 violations that has been fixed.
> This change contains only code formatting changes except few where I had to make minor changes.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml 510ddb111 
>   kms/src/main/java/javax/ws/rs/core/NoContentException.java b9366122d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 7bce126ce 
>   kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java f07a1fea8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java aec8eaeec 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java 39de0a503 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java 2740e4529 
>   kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 0cf832fd3 
>   kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java be369c95f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/KeySecureToRangerDBMKUtil.java 7fafa1052 
>   kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java d3b717a8a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 2998baa3c 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 2fa5c02f8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerAzureKeyVaultKeyGenerator.java 138a897bd 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java a61cabb1b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 90ef729b2 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java d5cdf18cd 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java b09cd5bad 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 39b5d65d1 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 957d2ca0e 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java db3750ecc 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 444092f34 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 4cad1e5d8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 632e728f4 
>   kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java e5ebeb783 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java 675a357f8 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 1fe7e25d6 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java e65577c98 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLsType.java 388cdd7ae 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 31f66384f 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuditLogger.java 8ae2ea3d9 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ed37df634 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSConfiguration.java 29f4a7d39 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b5be765e6 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJMXServlet.java 6918015a9 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONReader.java 59cc21823 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java a4e2b3042 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b975bd099 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java f1dca05fb 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSServerJSONUtils.java f4814865d 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java f7330a8b4 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java 8bcc6db5c 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/MetricREST.java f91902d1c 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/RangerKMSRestApi.java 04d26f7e7 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java c787806e2 
>   kms/src/main/java/org/apache/ranger/common/RangerJsonProvider.java cd5ad385a 
>   kms/src/main/java/org/apache/ranger/entity/XXDBBase.java cced013a1 
>   kms/src/main/java/org/apache/ranger/entity/XXRangerKeyStore.java 093cf5640 
>   kms/src/main/java/org/apache/ranger/entity/XXRangerMasterKey.java e0f147b85 
>   kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 8b0f74eac 
>   kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java 9e4d0bd89 
>   kms/src/main/java/org/apache/ranger/kms/dao/DaoManagerBase.java a5b4fe8a3 
>   kms/src/main/java/org/apache/ranger/kms/dao/RangerKMSDao.java 11a131f64 
>   kms/src/main/java/org/apache/ranger/kms/dao/RangerMasterKeyDao.java 93fc9fb11 
>   kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetricWrapper.java 1ff299242 
>   kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetrics.java 9c5bd3b9e 
>   kms/src/main/java/org/apache/ranger/kms/metrics/collector/KMSMetricsCollector.java 87391f3ea 
>   kms/src/main/java/org/apache/ranger/kms/metrics/source/KMSMetricSource.java 600e206e0 
>   kms/src/main/resources/hadoop-metrics2.properties df4d7eada 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java 16b374b51 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java 072c7f9f8 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java f89971876 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java a86ea02ce 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSACLs.java 03eaee82a 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 4e0b4ff80 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java 874232832 
>   kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java 3b74e3e71 
>   kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java 4609d1e1e 
>   kms/src/test/resources/hadoop-metrics2.properties f3897ba0b 
> 
> 
> Diff: https://reviews.apache.org/r/75319/diff/1/
> 
> 
> Testing
> -------
> 
> Project build (mvn clean install) was successful.
> ALL UTs passed.
> 
> 
> Thanks,
> 
> Vikas Kumar
> 
>

Re: Review Request 75319: RANGER-5035 : kms module: update for code readability improvement

Posted by Vikas Kumar <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75319/
-----------------------------------------------------------

(Updated Dec. 23, 2024, 11:45 a.m.)


Review request for ranger, Dhaval Shah, Madhan Neethiraj, and Sailaja Polavarapu.


Repository: ranger


Description
-------

Formatted KMS code to comply with Ranger code checkstyle rules.

Found around 169 violations that has been fixed.
This change contains only code formatting changes except few where I had to make minor changes.

GitHub PR: https://github.com/apache/ranger/pull/474


Diffs (updated)
-----

  kms/pom.xml 510ddb111 
  kms/src/main/java/javax/ws/rs/core/NoContentException.java b9366122d 
  kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 7bce126ce 
  kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java f07a1fea8 
  kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java aec8eaeec 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java 39de0a503 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java 2740e4529 
  kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 0cf832fd3 
  kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java be369c95f 
  kms/src/main/java/org/apache/hadoop/crypto/key/KeySecureToRangerDBMKUtil.java 7fafa1052 
  kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java d3b717a8a 
  kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 2998baa3c 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 2fa5c02f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAzureKeyVaultKeyGenerator.java 138a897bd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java a61cabb1b 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 90ef729b2 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java d5cdf18cd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java b09cd5bad 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 39b5d65d1 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 957d2ca0e 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java db3750ecc 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 444092f34 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 4cad1e5d8 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 632e728f4 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java e5ebeb783 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java 675a357f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 1fe7e25d6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java e65577c98 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLsType.java 388cdd7ae 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 31f66384f 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuditLogger.java 8ae2ea3d9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ed37df634 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSConfiguration.java 29f4a7d39 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b5be765e6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJMXServlet.java 6918015a9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONReader.java 59cc21823 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java a4e2b3042 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b975bd099 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java f1dca05fb 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSServerJSONUtils.java f4814865d 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java f7330a8b4 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java 8bcc6db5c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/MetricREST.java f91902d1c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/RangerKMSRestApi.java 04d26f7e7 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java c787806e2 
  kms/src/main/java/org/apache/ranger/common/RangerJsonProvider.java cd5ad385a 
  kms/src/main/java/org/apache/ranger/entity/XXDBBase.java cced013a1 
  kms/src/main/java/org/apache/ranger/entity/XXRangerKeyStore.java 093cf5640 
  kms/src/main/java/org/apache/ranger/entity/XXRangerMasterKey.java e0f147b85 
  kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 8b0f74eac 
  kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java 9e4d0bd89 
  kms/src/main/java/org/apache/ranger/kms/dao/DaoManagerBase.java a5b4fe8a3 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerKMSDao.java 11a131f64 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerMasterKeyDao.java 93fc9fb11 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetricWrapper.java 1ff299242 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetrics.java 9c5bd3b9e 
  kms/src/main/java/org/apache/ranger/kms/metrics/collector/KMSMetricsCollector.java 87391f3ea 
  kms/src/main/java/org/apache/ranger/kms/metrics/source/KMSMetricSource.java 600e206e0 
  kms/src/main/resources/hadoop-metrics2.properties df4d7eada 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java 16b374b51 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java 072c7f9f8 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java f89971876 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java a86ea02ce 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSACLs.java 03eaee82a 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 4e0b4ff80 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java 874232832 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java 3b74e3e71 
  kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java 4609d1e1e 
  kms/src/test/resources/hadoop-metrics2.properties f3897ba0b 


Diff: https://reviews.apache.org/r/75319/diff/3/

Changes: https://reviews.apache.org/r/75319/diff/2-3/


Testing
-------

Project build (mvn clean install) was successful.
ALL UTs passed.


Thanks,

Vikas Kumar

Re: Review Request 75319: RANGER-5035 : kms module: update for code readability improvement

Posted by Vikas Kumar <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75319/
-----------------------------------------------------------

(Updated Dec. 23, 2024, 11:07 a.m.)


Review request for ranger, Dhaval Shah, Madhan Neethiraj, and Sailaja Polavarapu.


Repository: ranger


Description (updated)
-------

Formatted KMS code to comply with Ranger code checkstyle rules.

Found around 169 violations that has been fixed.
This change contains only code formatting changes except few where I had to make minor changes.

GitHub PR: https://github.com/apache/ranger/pull/474


Diffs
-----

  kms/pom.xml 510ddb111 
  kms/src/main/java/javax/ws/rs/core/NoContentException.java b9366122d 
  kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 7bce126ce 
  kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java f07a1fea8 
  kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java aec8eaeec 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java 39de0a503 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java 2740e4529 
  kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 0cf832fd3 
  kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java be369c95f 
  kms/src/main/java/org/apache/hadoop/crypto/key/KeySecureToRangerDBMKUtil.java 7fafa1052 
  kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java d3b717a8a 
  kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 2998baa3c 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 2fa5c02f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAzureKeyVaultKeyGenerator.java 138a897bd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java a61cabb1b 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 90ef729b2 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java d5cdf18cd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java b09cd5bad 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 39b5d65d1 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 957d2ca0e 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java db3750ecc 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 444092f34 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 4cad1e5d8 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 632e728f4 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java e5ebeb783 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java 675a357f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 1fe7e25d6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java e65577c98 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLsType.java 388cdd7ae 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 31f66384f 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuditLogger.java 8ae2ea3d9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ed37df634 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSConfiguration.java 29f4a7d39 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b5be765e6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJMXServlet.java 6918015a9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONReader.java 59cc21823 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java a4e2b3042 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b975bd099 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java f1dca05fb 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSServerJSONUtils.java f4814865d 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java f7330a8b4 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java 8bcc6db5c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/MetricREST.java f91902d1c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/RangerKMSRestApi.java 04d26f7e7 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java c787806e2 
  kms/src/main/java/org/apache/ranger/common/RangerJsonProvider.java cd5ad385a 
  kms/src/main/java/org/apache/ranger/entity/XXDBBase.java cced013a1 
  kms/src/main/java/org/apache/ranger/entity/XXRangerKeyStore.java 093cf5640 
  kms/src/main/java/org/apache/ranger/entity/XXRangerMasterKey.java e0f147b85 
  kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 8b0f74eac 
  kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java 9e4d0bd89 
  kms/src/main/java/org/apache/ranger/kms/dao/DaoManagerBase.java a5b4fe8a3 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerKMSDao.java 11a131f64 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerMasterKeyDao.java 93fc9fb11 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetricWrapper.java 1ff299242 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetrics.java 9c5bd3b9e 
  kms/src/main/java/org/apache/ranger/kms/metrics/collector/KMSMetricsCollector.java 87391f3ea 
  kms/src/main/java/org/apache/ranger/kms/metrics/source/KMSMetricSource.java 600e206e0 
  kms/src/main/resources/hadoop-metrics2.properties df4d7eada 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java 16b374b51 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java 072c7f9f8 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java f89971876 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java a86ea02ce 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSACLs.java 03eaee82a 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 4e0b4ff80 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java 874232832 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java 3b74e3e71 
  kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java 4609d1e1e 
  kms/src/test/resources/hadoop-metrics2.properties f3897ba0b 


Diff: https://reviews.apache.org/r/75319/diff/2/


Testing
-------

Project build (mvn clean install) was successful.
ALL UTs passed.


Thanks,

Vikas Kumar

Re: Review Request 75319: RANGER-5035 : kms module: update for code readability improvement

Posted by Vikas Kumar <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75319/
-----------------------------------------------------------

(Updated Dec. 23, 2024, 11:06 a.m.)


Review request for ranger, Dhaval Shah, Madhan Neethiraj, and Sailaja Polavarapu.


Changes
-------

Incorporated all the review comments.


Repository: ranger


Description (updated)
-------

Formatted KMS code to comply with Ranger code checkstyle rules.

Found around 169 violations that has been fixed.
This change contains only code formatting changes except few where I had to make minor changes.

GutHub PR: https://github.com/apache/ranger/pull/474


Diffs (updated)
-----

  kms/pom.xml 510ddb111 
  kms/src/main/java/javax/ws/rs/core/NoContentException.java b9366122d 
  kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 7bce126ce 
  kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java f07a1fea8 
  kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java aec8eaeec 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToAzureKeyVault.java 39de0a503 
  kms/src/main/java/org/apache/hadoop/crypto/key/DBToKeySecure.java 2740e4529 
  kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java 0cf832fd3 
  kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java be369c95f 
  kms/src/main/java/org/apache/hadoop/crypto/key/KeySecureToRangerDBMKUtil.java 7fafa1052 
  kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java d3b717a8a 
  kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 2998baa3c 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 2fa5c02f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerAzureKeyVaultKeyGenerator.java 138a897bd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java a61cabb1b 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 90ef729b2 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java d5cdf18cd 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java b09cd5bad 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 39b5d65d1 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 957d2ca0e 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java db3750ecc 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 444092f34 
  kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 4cad1e5d8 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java 632e728f4 
  kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java e5ebeb783 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/EagerKeyGeneratorKeyProviderCryptoExtension.java 675a357f8 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 1fe7e25d6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java e65577c98 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLsType.java 388cdd7ae 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 31f66384f 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuditLogger.java 8ae2ea3d9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java ed37df634 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSConfiguration.java 29f4a7d39 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java b5be765e6 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJMXServlet.java 6918015a9 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONReader.java 59cc21823 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSJSONWriter.java a4e2b3042 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b975bd099 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java f1dca05fb 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSServerJSONUtils.java f4814865d 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java f7330a8b4 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java 8bcc6db5c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/MetricREST.java f91902d1c 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/RangerKMSRestApi.java 04d26f7e7 
  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java c787806e2 
  kms/src/main/java/org/apache/ranger/common/RangerJsonProvider.java cd5ad385a 
  kms/src/main/java/org/apache/ranger/entity/XXDBBase.java cced013a1 
  kms/src/main/java/org/apache/ranger/entity/XXRangerKeyStore.java 093cf5640 
  kms/src/main/java/org/apache/ranger/entity/XXRangerMasterKey.java e0f147b85 
  kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 8b0f74eac 
  kms/src/main/java/org/apache/ranger/kms/dao/BaseDao.java 9e4d0bd89 
  kms/src/main/java/org/apache/ranger/kms/dao/DaoManagerBase.java a5b4fe8a3 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerKMSDao.java 11a131f64 
  kms/src/main/java/org/apache/ranger/kms/dao/RangerMasterKeyDao.java 93fc9fb11 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetricWrapper.java 1ff299242 
  kms/src/main/java/org/apache/ranger/kms/metrics/KMSMetrics.java 9c5bd3b9e 
  kms/src/main/java/org/apache/ranger/kms/metrics/collector/KMSMetricsCollector.java 87391f3ea 
  kms/src/main/java/org/apache/ranger/kms/metrics/source/KMSMetricSource.java 600e206e0 
  kms/src/main/resources/hadoop-metrics2.properties df4d7eada 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java 16b374b51 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/DerbyTestUtils.java 072c7f9f8 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerKeyStoreProviderTest.java f89971876 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java a86ea02ce 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSACLs.java 03eaee82a 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 4e0b4ff80 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java 874232832 
  kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java 3b74e3e71 
  kms/src/test/java/org/apache/ranger/kms/metrics/TestKMSMetricsWrapper.java 4609d1e1e 
  kms/src/test/resources/hadoop-metrics2.properties f3897ba0b 


Diff: https://reviews.apache.org/r/75319/diff/2/

Changes: https://reviews.apache.org/r/75319/diff/1-2/


Testing
-------

Project build (mvn clean install) was successful.
ALL UTs passed.


Thanks,

Vikas Kumar