[GitHub] [flink] walterddr commented on issue #8468: [FLINK-12399][table] Adding PushDownTableSource interface to fix FilterableTableSource applyPredicate problem

[GitBox <gi...@apache.org>]

walterddr commented on issue #8468: [FLINK-12399][table] Adding PushDownTableSource interface to fix FilterableTableSource applyPredicate problem
URL: https://github.com/apache/flink/pull/8468#issuecomment-527983871
 
 
   Hi @KurtYoung yes. the purpose of this PR is to enforce user to explicitly override this API. since there's a `default String explainSource()` method in `TableSource`. it is likely that user will forget to override the method.
   
   Some alternative approach I can think of is
   1. generalize the "predicate" definition and put them in `ProjectableTableSource`: this allows a `default String explainPushdown()` similar to `TableSource` (thus backward compatible), but this require some additional changes (and deprecate marking of the current applyFilter/applyProject APIs)
   2. solution in https://github.com/apache/flink/pull/8389, in which I think the discussion lead to this PR :-)
   
   Do you think we need the additional API change? If not I think solution in #8389 also works. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services