You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/04/19 08:30:52 UTC
[GitHub] [arrow] wgtmac opened a new pull request, #35233: MINOR: [C++][Parquet] Fix column_reader_test
wgtmac opened a new pull request, #35233:
URL: https://github.com/apache/arrow/pull/35233
### Rationale for this change
https://github.com/apache/arrow/pull/14142 implemented the logic to skip parquet records and added a lot of test caese. However, there is a minor issue in the test function `RecordReaderPrimitiveTypeTest::CheckReadValues` where `!` is missing.
```c++
if (descr_->schema_node()->is_required()) {
std::vector<int16_t> read_defs(
record_reader_->def_levels(),
record_reader_->def_levels() + record_reader_->levels_position());
ASSERT_TRUE(vector_equal(expected_defs, read_defs));
}
```
### What changes are included in this PR?
Add `!` to `if (descr_->schema_node()->is_required())` as mentioned above.
### Are these changes tested?
This is a fix to the test case.
### Are there any user-facing changes?
NO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #35233: MINOR: [C++][Parquet] Fix column_reader_test
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #35233:
URL: https://github.com/apache/arrow/pull/35233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #35233: MINOR: [C++][Parquet] Fix column_reader_test
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #35233:
URL: https://github.com/apache/arrow/pull/35233#issuecomment-1514341824
cc @fatemehp @emkornfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35233: MINOR: [C++][Parquet] Fix column_reader_test
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35233:
URL: https://github.com/apache/arrow/pull/35233#issuecomment-1518232121
Benchmark runs are scheduled for baseline = 8e5f6c801886edffc20143c2329ffa46d8173891 and contender = f01853d775d484d644f9cb06f5bf06d32b6cc7b3. f01853d775d484d644f9cb06f5bf06d32b6cc7b3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7153e78630e846738dfd55d9b56a0ece...541e7deaa93a41f9b9d30ebd5ee97f59/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c3bcd6264d80429eb2c6f3be400813ed...88a36bd03b2248c9bddf053134a467bc/)
[Finished :arrow_down:1.28% :arrow_up:1.02%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cadbe95d7bdd499a8fe6f4b873a20683...7bfba98e22c34f08a25ff5251be2f274/)
[Finished :arrow_down:0.42% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a897256ec758410ebd8a163e6e078ff1...6e9d04e80ef14231bc710c62621e1dd2/)
Buildkite builds:
[Finished] [`f01853d7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2755)
[Failed] [`f01853d7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2789)
[Finished] [`f01853d7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2753)
[Finished] [`f01853d7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2780)
[Finished] [`8e5f6c80` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2754)
[Failed] [`8e5f6c80` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2788)
[Finished] [`8e5f6c80` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2752)
[Finished] [`8e5f6c80` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2779)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35233: MINOR: [C++][Parquet] Fix column_reader_test
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35233:
URL: https://github.com/apache/arrow/pull/35233#issuecomment-1518232702
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cadbe95d7bdd499a8fe6f4b873a20683...7bfba98e22c34f08a25ff5251be2f274/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org