You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tian-pengfei (via GitHub)" <gi...@apache.org> on 2023/05/01 05:47:33 UTC
[GitHub] [shenyu] tian-pengfei opened a new pull request, #4600: [ISSUE #4560] spring-mvc(boot) client support collect api-meta
tian-pengfei opened a new pull request, #4600:
URL: https://github.com/apache/shenyu/pull/4600
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
Implements #4560
exmaple:
`@EnableClientRegister`
```java
@SpringBootApplication
@EnableClientRegister
public class ShenyuTestHttpApplication {
/**
* main.
*
* @param args args
*/
public static void main(final String[] args) {
SpringApplication.run(ShenyuTestHttpApplication.class, args);
}
}
```
Collection rules
1.only class is annotated by `@ShenyuSpringMvcClient` ,api-method will be collected.
```java
@ShenyuSpringMvcClient
@RestController
@RequestMapping("/testClass")
class TestBeanMatchClass {
@RequestMapping("/testMethod")
public String testMethod() {
return "";
}
}
```
`apiPath = "/testClass/testMethod"`
2.Only metod is annotated by `@ShenyuSpringMvcClient` ,api-method will be collected.
```java
@RestController
@RequestMapping("/testClass")
class TestBeanMatchClass {
@RequestMapping("/testMethod")
@ShenyuSpringMvcClient
public String testMethod() {
return "";
}
}
```
`apiPath = "/testClass/testMethod"`
3.Class is annotated by `@ShenyuSpringMvcClient` , but path end with `/**` , The class will be collected as a api meta
```java
@RestController
@ShenyuSpringMvcClient("/testClass/**")
@RequestMapping("/testClass")
class TestBeanMatchClass {
@RequestMapping("/testMethod")
@ShenyuSpringMvcClient
public String testMethod() {
return "";
}
@RequestMapping("/testMethod2")
@ShenyuSpringMvcClient
public String testMethod2() {
return "";
}
}
```
`apiPath = "/testClass/**"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4600: [ISSUE #4560] spring-mvc(boot) client support collect api-meta
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4600:
URL: https://github.com/apache/shenyu/pull/4600#issuecomment-1529444752
## [Codecov](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4600](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e8f6c5) into [master](https://codecov.io/gh/apache/shenyu/commit/2874ec7ce44d0ab13a7004bc77fd93d2c293f88d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2874ec7) will **decrease** coverage by `0.03%`.
> The diff coverage is `70.08%`.
```diff
@@ Coverage Diff @@
## master #4600 +/- ##
============================================
- Coverage 69.18% 69.15% -0.03%
- Complexity 7822 7849 +27
============================================
Files 1037 1044 +7
Lines 29901 30018 +117
Branches 2726 2738 +12
============================================
+ Hits 20686 20760 +74
- Misses 7594 7628 +34
- Partials 1621 1630 +9
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...vc/register/SpringMvcApiDefinitionMetaMatcher.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaURlZmluaXRpb25NZXRhTWF0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../springmvc/ShenyuSpringMvcClientConfiguration.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L3NwcmluZ212Yy9TaGVueXVTcHJpbmdNdmNDbGllbnRDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...henyuSpringMvcClientInfoRegisterConfiguration.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L3NwcmluZ212Yy9TaGVueXVTcHJpbmdNdmNDbGllbnRJbmZvUmVnaXN0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mvc/register/SpringMvcApiMetaDefinitionParser.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaU1ldGFEZWZpbml0aW9uUGFyc2VyLmphdmE=) | `85.71% <85.71%> (ø)` | |
| [...springmvc/register/SpringMvcApiBeansExtractor.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `88.46% <88.46%> (ø)` | |
| [...pringmvc/register/SpringMvcApiMetaBeanMatcher.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaU1ldGFCZWFuTWF0Y2hlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ngmvc/register/SpringMvcPreApiMetaBeanMatcher.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y1ByZUFwaU1ldGFCZWFuTWF0Y2hlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ingmvc/register/SpringMvcPreApiMetaBeanParser.java](https://codecov.io/gh/apache/shenyu/pull/4600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y1ByZUFwaU1ldGFCZWFuUGFyc2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://codecov.io/gh/apache/shenyu/pull/4600/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei merged pull request #4600: [ISSUE #4560] spring-mvc(boot) client support collect api-meta
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei merged PR #4600:
URL: https://github.com/apache/shenyu/pull/4600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org