You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/10/02 14:00:51 UTC

[GitHub] [parquet-mr] belugabehr opened a new pull request #822: PARQUET-1918: Avoid Copy of Bytes in Protobuf BinaryWriter

belugabehr opened a new pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [PARQUET-1918](https://issues.apache.org/jira/browse/PARQUET-1918) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: performance change, not functionality.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #822: PARQUET-1918: Avoid Copy of Bytes in Protobuf BinaryWriter

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822#issuecomment-714533411


   @belugabehr, what about blocking the jira with the thrift ticket so it is clear why we cannot step forward?
   Also, after fixing THRIFT-5288 we have to fix `Binary` as well and maybe other points in the code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] belugabehr edited a comment on pull request #822: PARQUET-1918: Avoid Copy of Bytes in Protobuf BinaryWriter

Posted by GitBox <gi...@apache.org>.
belugabehr edited a comment on pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822#issuecomment-714521089


   @gszadovszky Ya. I did discover that this is a bit more tricky than I had anticipated.  My expectation was that ByteBuffers were handled the same way as there are defined in the JDK specs (most methods have the side-affect of moving Buffer positions around). This particular work is blocked as I try to improve ByteBuffer handling in Thrift first: THRIFT-5288


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] belugabehr commented on pull request #822: PARQUET-1918: Avoid Copy of Bytes in Protobuf BinaryWriter

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822#issuecomment-714521089


   @gszadovszky Ya. I did discover that this is a bit more tricky than I had anticipated.  My expectation was this ByteBuffers were handled the same way as there are defined in the JDK specs (most methods have the side-affect of moving Buffer positions around). This particular work is blocked as I try to improve ByteBuffer handling in Thrift first: THRIFT-5288


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org