[GitHub] [kafka] bruto1 edited a comment on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

[GitBox <gi...@apache.org>]

bruto1 edited a comment on pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#issuecomment-841806011


   > Hi @bruto1 can you take a look at PlaintextConsumerTest.testHeadersSerializerDeserializer()? It seems to be failing and might be related to your change.
   
   there're quite a few tests failing in every PR in this repo, it seems :)
   the test you mentioned does not have any relation to my changes as it uses byte[] for value
   
   the failure occurs outside of code modified by me:
   ```
   java.lang.IllegalStateException: RecordHeaders has been closed.
   	at org.apache.kafka.common.header.internals.RecordHeaders.canWrite(RecordHeaders.java:122)
   	at org.apache.kafka.common.header.internals.RecordHeaders.add(RecordHeaders.java:61)
   	at org.apache.kafka.common.header.internals.RecordHeaders.add(RecordHeaders.java:68)
   	at kafka.api.PlaintextConsumerTest$SerializerImpl.serialize(PlaintextConsumerTest.scala:76)
   	at kafka.api.PlaintextConsumerTest$SerializerImpl.serialize$(PlaintextConsumerTest.scala:75)
   	at kafka.api.PlaintextConsumerTest$$anon$1.serialize(PlaintextConsumerTest.scala:142)
   	at kafka.api.PlaintextConsumerTest$$anon$1.serialize(PlaintextConsumerTest.scala:142)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org