You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2019/07/17 08:56:41 UTC

[GitHub] [hive] miklosgergely commented on a change in pull request #720: HIVE-21977 Clean up DescTableOperation

miklosgergely commented on a change in pull request #720: HIVE-21977 Clean up DescTableOperation
URL: https://github.com/apache/hive/pull/720#discussion_r304290846
 
 

 ##########
 File path: ql/src/test/results/clientpositive/alterColumnStats.q.out
 ##########
 @@ -144,35 +144,15 @@ PREHOOK: Input: default@p_n0
 POSTHOOK: query: desc formatted p_n0 c1
 POSTHOOK: type: DESCTABLE
 POSTHOOK: Input: default@p_n0
-col_name            	c1                  	 	 	 	 	 	 	 	 	 	 
-data_type           	string              	 	 	 	 	 	 	 	 	 	 
-min                 	                    	 	 	 	 	 	 	 	 	 	 
 
 Review comment:
   Hive either shows the data in the vertical format, which is supposed to be shown in case of having statistics, and the horizontal format with fewer fields, when we don't have the statistics. The previous somewhat messy code produced anomalies like this one, that we didn't have the statistics, still it was shown in vertical format. After the cleanup that small bug is also fixed, like in this case: we don't have statistics, so it is shown in horizontal format.
   
   In other files for example alter_table_column_stats.q.out there are statistics, and thus there is still vertical format present with data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org