You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/10/10 20:28:24 UTC
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request
#2457: Add TO Go post deliveryservice_user
mhoppa commented on a change in pull request #2457: Add TO Go post deliveryservice_user
URL: https://github.com/apache/trafficcontrol/pull/2457#discussion_r333692381
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -557,6 +557,23 @@ type DeliveryServiceUserPost struct {
Replace *bool `json:"replace"`
}
+func (dsu *DeliveryServiceUserPost) Validate(tx *sql.Tx) error {
+ errs := []string{}
+ if dsu.UserID == nil {
Review comment:
nit but should we use ozzo-validation for this. I know doesn't really buy you anything as they are just nil checks but would be nice to start enforcing consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services