You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/08/06 04:26:37 UTC

[GitHub] carbondata pull request #2607: [CARBONDATA-2818] Presto Upgrade to 0.206

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2607#discussion_r207771253
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java ---
    @@ -73,7 +73,7 @@ public static CarbonVectorBatch allocate(StructField[] schema,
       }
     
       private CarbonColumnVectorImpl createDirectStreamReader(int batchSize, DataType dataType,
    -      StructField field, Dictionary dictionary, SliceArrayBlock dictionarySliceArrayBlock) {
    +      StructField field, Dictionary dictionary, Block dictionarySliceArrayBlock) {
    --- End diff --
    
    better to modify the names also for readability and maintainability purpose.  
    dictionarySliceArrayBlock --> dictionaryBlock


---