You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/09 09:01:31 UTC

[GitHub] XD-DENG edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

XD-DENG edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()
URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411683117
 
 
   Thanks @feng-tao .  
   
   Not sure whether Ad Hoc Query can be considered safe under `Admin` role. But given it's a decision already made by the community,  I'm totally ok and fully understand the reasons for what the decision was made. @bolkedebruin please given your input?
   
   On the other hand, would it be worthwhile to merge my change on file [`airflow/www/views.py`](https://github.com/apache/incubator-airflow/pull/3718/files#diff-948e87b4f8f644b3ad8c7950958df033) (which was the initial purpose of this PR)? It's a refinement on the `/www`. It may be up to how soon we're going to remove `/www`. 
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services