You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/23 04:24:36 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5138: move Java modules job to 11
mbien opened a new pull request, #5138:
URL: https://github.com/apache/netbeans/pull/5138
wip
assuming this works, job will need some step deduplication and cleanup
meta issue #4904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#issuecomment-1374397592
@neilcsmith-net I have this one set for NB17 since this reduces the longest job by about 30mins, since releasing does require a lot of building I thought it would be good to get this one in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#issuecomment-1368155865
@jlahoda would be good if you could take a look at this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056861917
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
actually, i got an idea while waiting for Santa.
we can simply unset the default flags of the compiler category:
```
# remove default compiler JMS flags so that we don't get "Unknown module" warnings due to --limit-modules
jms-compiler.flags.jvm=
```
since we did put them into categories already (#3658) we may as well make use of that fact :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056670162
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
this has almost the same effect as the old CI config line:
```
OPTS_11=-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
```
the difference is that the entire run args property isn't overwritten which is set up here:
https://github.com/apache/netbeans/blob/30a8cefa5a73f258b61939729e845672e66826fe/nbbuild/templates/projectized.xml#L293
this has however the side effect of warnings like:
`WARNING: Unknown module: jdk.compiler specified to --add-exports`
I am wondering if i should set `metabuild.jms-flags.jvm` to an empty string in the project configs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056861917
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
actually, i got an idea while waiting for Santa.
we can simply unset the default flags of the compiler category:
```
# remove default compiler JMS flags so that we don't get "Unknown module" warnings due to --limit-modules
jms-compiler.flags.jvm=
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056861917
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
actually, i got an idea while waiting for Santa.
we can simply unset the default flags of the compiler category:
```
# remove default compiler JMS flags so that we don't get "Unknown module" warnings due to --limit-modules
jms-compiler.flags.jvm=
```
since we did put them into categories already we may as well make use of that fact :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056861917
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
actually, i got an idea while waiting for Santa.
we can simply unset the default flags of the compiler category:
```
# remove default compiler JMS flags so that we don't get "Unknown module" warnings due to --limit-modules
jms-compiler.flags.jvm=
```
since we split them into categories already (#3658) we may as well make use of that fact :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056670162
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
this has almost the same effect as the old CI config line:
```
OPTS_11=-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
```
the difference is that the entire run args property isn't overwritten which is set up here:
https://github.com/apache/netbeans/blob/30a8cefa5a73f258b61939729e845672e66826fe/nbbuild/templates/projectized.xml#L293
this has however the side effect of warnings like:
`WARNING: Unknown module: jdk.compiler specified to --add-exports`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056670162
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
this has almost the same effect as the old CI config line:
```
OPTS_11=-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
```
the difference is that the entire run args property isn't overwritten which is set up here:
https://github.com/apache/netbeans/blob/30a8cefa5a73f258b61939729e845672e66826fe/nbbuild/templates/projectized.xml#L293
this has however has the side effect of warnings like:
`WARNING: Unknown module: jdk.compiler specified to --add-exports`
I am wondering if i should set `metabuild.jms-flags.jvm` to an empty string in the project configs I touched in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056670162
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
this has almost the same effect as the old CI config line:
```
OPTS_11=-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
```
the difference is that the entire run args property isn't overwritten which is set up here:
https://github.com/apache/netbeans/blob/30a8cefa5a73f258b61939729e845672e66826fe/nbbuild/templates/projectized.xml#L293
this has however has the side effect of warnings like:
`WARNING: Unknown module: jdk.compiler specified to --add-exports`
I am wondering if i should set `metabuild.jms-flags.jvm` to an empty string in the project configs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#issuecomment-1376721638
thanks for the review. Lets get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien merged PR #5138:
URL: https://github.com/apache/netbeans/pull/5138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056861917
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
actually, i got an idea while waiting for Santa.
we can simply unset the default flags of the compiler category:
```
# remove default compiler JMS flags so that we don't get "Unknown module" warnings due to --limit-modules
jms-compiler.flags.jvm=
```
since we did split them into categories already (#3658) we may as well make use of that fact :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5138: move java modules job to JDK 11 and fix tests where needed
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5138:
URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056670162
##########
java/java.completion/nbproject/project.properties:
##########
@@ -31,3 +31,6 @@ test.timeout=1200000
# requires nb.javac for compiling of tests on Mac
requires.nb.javac=true
+
+test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming
+test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
Review Comment:
this has almost the same effect as the old CI config line:
```
OPTS_11=-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true
```
the difference is that the entire run args property isn't overwritten which is set up here:
https://github.com/apache/netbeans/blob/30a8cefa5a73f258b61939729e845672e66826fe/nbbuild/templates/projectized.xml#L293
this has however the side effect of warnings like:
`WARNING: Unknown module: jdk.compiler specified to --add-exports`
I am wondering if i should set `metabuild.jms-flags.jvm` to an empty string in the project configs I touched in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists