You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "aliehsaeedii (via GitHub)" <gi...@apache.org> on 2025/03/10 12:30:34 UTC
[PR] KAFKA-18739 Add group level Sstreams configuration [kafka]
aliehsaeedii opened a new pull request, #19176:
URL: https://github.com/apache/kafka/pull/19176
This PR implements the configs proposed in [KIP-1071](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627992#KIP1071:StreamsRebalanceProtocol-BrokerConfigurations)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #19176:
URL: https://github.com/apache/kafka/pull/19176#issuecomment-2718102555
@aliehsaeedii there seem to be test fialures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993412715
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -160,13 +160,15 @@ class KafkaApisTest extends Logging {
}
def createKafkaApis(
+ newGroupCoordiantorEnable: Boolean = true,
authorizer: Option[Authorizer] = None,
configRepository: ConfigRepository = new MockConfigRepository(),
overrideProperties: Map[String, String] = Map.empty,
featureVersions: Seq[FeatureVersion] = Seq.empty
): KafkaApis = {
val properties = TestUtils.createBrokerConfig(brokerId)
+ properties.put(GroupCoordinatorConfig.NEW_GROUP_COORDINATOR_ENABLE_CONFIG, newGroupCoordiantorEnable)
Review Comment:
remove
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -336,6 +338,11 @@ class KafkaApisTest extends Logging {
cgConfigs.put(SHARE_HEARTBEAT_INTERVAL_MS_CONFIG, GroupCoordinatorConfig.SHARE_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT.toString)
cgConfigs.put(SHARE_RECORD_LOCK_DURATION_MS_CONFIG, ShareGroupConfig.SHARE_GROUP_RECORD_LOCK_DURATION_MS_DEFAULT.toString)
cgConfigs.put(SHARE_AUTO_OFFSET_RESET_CONFIG, GroupConfig.SHARE_AUTO_OFFSET_RESET_DEFAULT)
+ cgConfigs.put(STREAMS_HEARTBEAT_INTERVAL_MS_CONFIG, GroupCoordinatorConfig.STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT.toString)
+ cgConfigs.put(STREAMS_SESSION_TIMEOUT_MS_CONFIG, GroupCoordinatorConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_DEFAULT.toString)
+ cgConfigs.put(STREAMS_NUM_STANDBY_REPLICAS_CONFIG, GroupCoordinatorConfig.STREAMS_GROUP_NUM_STANDBY_REPLICAS_DEFAULT.toString)
+
+
Review Comment:
remove double newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "aliehsaeedii (via GitHub)" <gi...@apache.org>.
aliehsaeedii commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993160116
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1034,6 +1034,16 @@ class KafkaConfigTest {
case ShareGroupConfig.SHARE_GROUP_PERSISTER_CLASS_NAME_CONFIG => //ignore string
case ShareGroupConfig.SHARE_FETCH_MAX_FETCH_RECORDS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number")
+ /** Streams groups configs */
+ case GroupCoordinatorConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_SIZE_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", -1)
Review Comment:
not any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993409951
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -413,7 +413,7 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
}
if (protocols.contains(GroupType.STREAMS)) {
if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
- throw new ConfigException(s"The new '${GroupType.STREAMS}' rebalance protocol is only supported in KRaft cluster with the new group coordinator.")
+ warn(s"The new '${GroupType.STREAMS}' rebalance protocol is only supported in KRaft cluster with the new group coordinator.")
Review Comment:
remove kraft. also `processRoles`. Compare to the other group types above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993118985
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1034,6 +1034,16 @@ class KafkaConfigTest {
case ShareGroupConfig.SHARE_GROUP_PERSISTER_CLASS_NAME_CONFIG => //ignore string
case ShareGroupConfig.SHARE_FETCH_MAX_FETCH_RECORDS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number")
+ /** Streams groups configs */
+ case GroupCoordinatorConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_SIZE_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", -1)
Review Comment:
0 should also be invalid
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -160,13 +160,15 @@ class KafkaApisTest extends Logging {
}
def createKafkaApis(
+ newGroupCoordiantorEnable: Boolean = true,
Review Comment:
That seems like very significant change. It shouldn't be necessary to enable the new group coordinator here. What are you trying to fix with this?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -331,7 +331,7 @@ public class GroupCoordinatorConfig {
.define(STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG, INT, STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM, STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
.define(STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG, INT, STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM, STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DOC)
.define(STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG, INT, STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM, STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC)
- .define(STREAMS_GROUP_MAX_SIZE_CONFIG, INT, STREAMS_GROUP_MAX_SIZE_DEFAULT, MEDIUM, STREAMS_GROUP_MAX_SIZE_DOC)
+ .define(STREAMS_GROUP_MAX_SIZE_CONFIG, INT, STREAMS_GROUP_MAX_SIZE_DEFAULT, atLeast(0), MEDIUM, STREAMS_GROUP_MAX_SIZE_DOC)
Review Comment:
What sense does it make to allow groups of size 0? I would use `atLeast(1)` as for the other groups.
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -413,10 +413,8 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _])
}
if (protocols.contains(GroupType.STREAMS)) {
if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
- throw new ConfigException(s"The new '${GroupType.STREAMS}' rebalance protocol is only supported in KRaft cluster with the new group coordinator.")
+ warn(s"The new '${GroupType.STREAMS}' rebalance protocol is only supported in KRaft cluster with the new group coordinator.")
}
- warn(s"The new '${GroupType.STREAMS}' rebalance protocol is enabled along with the new group coordinator. " +
- "This is part of the preview of KIP-1071 and MUST NOT be used in production.")
}
Review Comment:
Why are you removing the warning that KIP-1071 must not be used in production?
Let's follow the same code as share groups above. I agree that we don't have to throw an exception here. We also shouldn't mention Kraft anymore, since ZooKeeper is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "aliehsaeedii (via GitHub)" <gi...@apache.org>.
aliehsaeedii commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993160116
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1034,6 +1034,16 @@ class KafkaConfigTest {
case ShareGroupConfig.SHARE_GROUP_PERSISTER_CLASS_NAME_CONFIG => //ignore string
case ShareGroupConfig.SHARE_FETCH_MAX_FETCH_RECORDS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number")
+ /** Streams groups configs */
+ case GroupCoordinatorConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", 0, -1)
+ case GroupCoordinatorConfig.STREAMS_GROUP_MAX_SIZE_CONFIG => assertPropertyInvalid(baseProperties, name, "not_a_number", -1)
Review Comment:
not any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "aliehsaeedii (via GitHub)" <gi...@apache.org>.
aliehsaeedii commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993159215
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -160,13 +160,15 @@ class KafkaApisTest extends Logging {
}
def createKafkaApis(
+ newGroupCoordiantorEnable: Boolean = true,
Review Comment:
It is `true` by default. That's why `testStreamsGroupHeartbeatReturnsUnsupportedVersion` and `testStreamsGroupDescribeReturnsUnsupportedVersion` were failing. I had to set it to `false` here: https://github.com/aliehsaeedii/kafka/blob/cf9e8e397a186cff3cd2ab81ac7a610e9be47985/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala#L10408 and here: https://github.com/aliehsaeedii/kafka/blob/cf9e8e397a186cff3cd2ab81ac7a610e9be47985/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala#L9937 to make the tests working again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18739 Add group level Sstreams configuration [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1987359087
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -238,6 +239,45 @@ public class GroupCoordinatorConfig {
public static final int SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT = 15000;
public static final String SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC = "The maximum heartbeat interval for share group members.";
+ ///
+ /// Streams group configs
+ ///
+ public static final String STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG = "group.streams.session.timeout.ms";
+ public static final int STREAMS_GROUP_SESSION_TIMEOUT_MS_DEFAULT = 45000;
+ public static final String STREAMS_GROUP_SESSION_TIMEOUT_MS_DOC = "The timeout to detect client failures when using the streams group protocol.";
+
+ public static final String STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG = "group.streams.min.session.timeout.ms";
+ public static final int STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_DEFAULT = 45000;
+ public static final String STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_DOC = "The minimum session timeout.";
Review Comment:
I wonder if it wouldn't be clearer if we refer to specific configurations here:
```
"The minimum for the group-level configuration of " + GroupConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG
```
Same for all the other min/max configs below.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -59,6 +59,18 @@ public final class GroupConfig extends AbstractConfig {
"Negative duration is not allowed.</li>" +
"<li>anything else: throw exception to the share consumer.</li></ul>";
+ public static final String STREAMS_SESSION_TIMEOUT_MS_CONFIG = "group.streams.session.timeout.ms";
+ public static final int STREAMS_SESSION_TIMEOUT_MS_DEFAULT = 45000;
Review Comment:
For the defaults and docs in this file, I would just reference the `GroupCoordinatorConfig` variants instead of creating a duplicate here, like the other group types do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993408506
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -68,7 +68,8 @@ public class GroupCoordinatorConfig {
"The " + Group.GroupType.SHARE + " rebalance protocol is in early access and therefore must not be used in production.";
public static final List<String> GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT = List.of(
Group.GroupType.CLASSIC.toString(),
- Group.GroupType.CONSUMER.toString()
+ Group.GroupType.CONSUMER.toString(),
+ Group.GroupType.STREAMS.toString()
Review Comment:
We do not want to enable the streams protocol by default!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "aliehsaeedii (via GitHub)" <gi...@apache.org>.
aliehsaeedii commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993160914
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -331,7 +331,7 @@ public class GroupCoordinatorConfig {
.define(STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG, INT, STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM, STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_DOC)
.define(STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG, INT, STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM, STREAMS_GROUP_MIN_HEARTBEAT_INTERVAL_MS_DOC)
.define(STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG, INT, STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT, atLeast(1), MEDIUM, STREAMS_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC)
- .define(STREAMS_GROUP_MAX_SIZE_CONFIG, INT, STREAMS_GROUP_MAX_SIZE_DEFAULT, MEDIUM, STREAMS_GROUP_MAX_SIZE_DOC)
+ .define(STREAMS_GROUP_MAX_SIZE_CONFIG, INT, STREAMS_GROUP_MAX_SIZE_DEFAULT, atLeast(0), MEDIUM, STREAMS_GROUP_MAX_SIZE_DOC)
Review Comment:
no sense @lucasbru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #19176:
URL: https://github.com/apache/kafka/pull/19176#discussion_r1993412379
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -10398,7 +10405,7 @@ class KafkaApisTest extends Logging {
cache.setImage(delta.apply(MetadataProvenance.EMPTY))
cache
}
- kafkaApis = createKafkaApis()
+ kafkaApis = createKafkaApis(newGroupCoordiantorEnable = false)
Review Comment:
remove
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -9927,7 +9934,7 @@ class KafkaApisTest extends Logging {
cache.setImage(delta.apply(MetadataProvenance.EMPTY))
cache
}
- kafkaApis = createKafkaApis()
+ kafkaApis = createKafkaApis(newGroupCoordiantorEnable = false)
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru merged PR #19176:
URL: https://github.com/apache/kafka/pull/19176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org