You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/02 07:43:55 UTC

[GitHub] [airflow] uranusjr commented on pull request #26105: Fix: git clone on Windows

uranusjr commented on PR #26105:
URL: https://github.com/apache/airflow/pull/26105#issuecomment-1235178164

   I commented elsewhere. Since this actually affects Windows _support_ (which we want to achieve at some point), the root cause should also be fixed. I would suggest the following steps:
   
   1. Fix the actual `FileTaskHandler` to log in different a file name format in Windows.
   2. Delete those problematic files from the repository, and general those files dynamically when testing (under appropriate file names) instead in Pytest’s `tmp_path`.
   3. Modify tests to appropriately point the log directory to `tmp_path`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org