You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/02 13:03:55 UTC

[GitHub] [camel-k] claudio4j commented on a diff in pull request #3871: fix(service): Create k8s service when knative-service trait is disabled

claudio4j commented on code in PR #3871:
URL: https://github.com/apache/camel-k/pull/3871#discussion_r1038123320


##########
pkg/trait/service.go:
##########
@@ -46,7 +46,7 @@ func newServiceTrait() Trait {
 // IsAllowedInProfile overrides default.
 func (t *serviceTrait) IsAllowedInProfile(profile v1.TraitProfile) bool {
 	return profile.Equal(v1.TraitProfileKubernetes) ||
-		profile.Equal(v1.TraitProfileOpenShift)
+		profile.Equal(v1.TraitProfileOpenShift) || profile.Equal(v1.TraitProfileKnative)

Review Comment:
   Oh, yes, thanks for noticing this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org