You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 04:39:52 UTC
[GitHub] [arrow] AlenkaF opened a new pull request, #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
AlenkaF opened a new pull request, #12930:
URL: https://github.com/apache/arrow/pull/12930
Trying to fix failing nightly-packaging jobs for windows wheels:
- [wheel-windows-cp310-amd64](https://github.com/ursacomputing/crossbow/tree/nightly-packaging-2022-04-18-0-github-wheel-windows-cp310-amd64)
- [wheel-windows-cp39-amd64](https://github.com/ursacomputing/crossbow/tree/nightly-packaging-2022-04-18-0-github-wheel-windows-cp39-amd64)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103536707
Revision: 2c7708717f803fa1edc9fdf3381144484f309d3d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1881](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1881)
|Task|Status|
|----|------|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1881-github-test-conda-python-3.8-hypothesis)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103778996
Thanks @kszucs!
Linter error is triggered because `tzdata` is not used directly in the code (but needs to be installed on Windows).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103504565
Revision: c41670f33d322c644f60f4f2bfb2f2d71643128b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1880](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1880)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1880-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1880-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1880-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1880-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853903483
##########
python/pyarrow/tests/strategies.py:
##########
@@ -29,6 +30,11 @@
import zoneinfo
except ImportError:
zoneinfo = None
+if sys.platform == 'win32':
+ try:
+ import tzdata
+ except ImportError:
+ tzdata = None
Review Comment:
Yes, thought about this too! Will do 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103465089
Revision: 954100049a2b2d084350057d88623c67b6af51ed
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1879](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1879)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1879-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1879-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1879-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1879-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103464416
https://issues.apache.org/jira/browse/ARROW-16233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103534772
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103506816
Will take a look at hypothesis tests also! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103769858
Revision: ca4c9b620d73dd6e3bcabf5c90b156a44c4eec8b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1884](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1884)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1884-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1884-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1884-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1884-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
URL: https://github.com/apache/arrow/pull/12930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853757108
##########
ci/docker/python-wheel-windows-vs2017.dockerfile:
##########
@@ -83,7 +83,7 @@ RUN choco install -r -y --no-progress python --version=%PYTHON_VERSION%
RUN python -m pip install -U pip setuptools
COPY python/requirements-wheel-build.txt arrow/python/
-RUN python -m pip install -r arrow/python/requirements-wheel-build.txt
+RUN python -m pip install tzdata -r arrow/python/requirements-wheel-build.txt
Review Comment:
Great, thanks for the pointers! I wasn't sure where to put it =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103759893
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103768736
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853885139
##########
ci/scripts/python_wheel_windows_test.bat:
##########
@@ -35,7 +35,7 @@ set ARROW_TEST_DATA=C:\arrow\testing\data
set PARQUET_TEST_DATA=C:\arrow\submodules\parquet-testing\data
@REM Install testing dependencies
-pip install -r C:\arrow\python\requirements-wheel-test.txt || exit /B 1
+pip install tzdata -r C:\arrow\python\requirements-wheel-test.txt || exit /B 1
Review Comment:
Alternatively, we could also add it to `requirements-wheel-test.txt`? (with "environment markers", it should be possible to list a package only for windows, see https://peps.python.org/pep-0496/#examples)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103464425
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103759668
@github-actions crossbow submit test-conda-python-3.8-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103772507
> Failed to push updated references, potentially because of credential issues: ['refs/heads/actions-1883-github-wheel-windows-cp310-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp310-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp39-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp39-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp37-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp37-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp38-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp38-amd64', 'refs/heads/actions-1883']
> The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2195038965```
This is probably caused by a race condition, another submission gets that auto incremented build ID earlier. We should remove the auto incremented IDs entirely and use unique hashes instead, e.g.: `actions-<short-hash>-github-wheel-windows-cp310-amd64` instead of `actions-1883-github-wheel-windows-cp310-amd64`. Then we wouldn't need to fetch the new references either making crossbow builds and local usage much quicker.
fyi @raulcd @assignUser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103764216
```
Failed to push updated references, potentially because of credential issues: ['refs/heads/actions-1883-github-wheel-windows-cp310-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp310-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp39-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp39-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp37-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp37-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp38-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp38-amd64', 'refs/heads/actions-1883']
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2195038965```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853755786
##########
ci/docker/python-wheel-windows-vs2017.dockerfile:
##########
@@ -83,7 +83,7 @@ RUN choco install -r -y --no-progress python --version=%PYTHON_VERSION%
RUN python -m pip install -U pip setuptools
COPY python/requirements-wheel-build.txt arrow/python/
-RUN python -m pip install -r arrow/python/requirements-wheel-build.txt
+RUN python -m pip install tzdata -r arrow/python/requirements-wheel-build.txt
Review Comment:
And checking the log output, you can indeed already see that the above did not work to install tzdata in the test, because the skip is correctly working: https://github.com/ursacomputing/crossbow/runs/6089209704?check_suite_focus=true#step:7:441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103503769
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103464524
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103537850
Revision: 2c7708717f803fa1edc9fdf3381144484f309d3d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1882](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1882)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1882-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1882-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1882-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1882-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853887418
##########
python/pyarrow/tests/strategies.py:
##########
@@ -29,6 +30,11 @@
import zoneinfo
except ImportError:
zoneinfo = None
+if sys.platform == 'win32':
+ try:
+ import tzdata
+ except ImportError:
+ tzdata = None
Review Comment:
Potential idea to simplify this: in this case we could also set `zoneinfo = None`, and keep the below code similar (then we only need to check `zoneinfo` to see if the test should be skipped or not). We could then just update the skip message to something like "no module named zoneinfo (or tzdata on Windows)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853754830
##########
ci/docker/python-wheel-windows-vs2017.dockerfile:
##########
@@ -83,7 +83,7 @@ RUN choco install -r -y --no-progress python --version=%PYTHON_VERSION%
RUN python -m pip install -U pip setuptools
COPY python/requirements-wheel-build.txt arrow/python/
-RUN python -m pip install -r arrow/python/requirements-wheel-build.txt
+RUN python -m pip install tzdata -r arrow/python/requirements-wheel-build.txt
Review Comment:
I think the tzdata should be installed in the env for testing the wheel, and shouldn't be required when _building_.
We do have a `python_wheel_windows_test.bat` script which I suppose is relevant here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103534626
@github-actions crossbow submit test-conda-python-3.8-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1103763969
Revision: ca4c9b620d73dd6e3bcabf5c90b156a44c4eec8b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1883](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1883)
|Task|Status|
|----|------|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1883-github-test-conda-python-3.8-hypothesis)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1104875876
Just one thing, a linting error .. `/arrow/python/pyarrow/tests/strategies.py:35:9: F401 'tzdata' imported but unused`. You will probably need to add a ` # noqa` behind the tzdata import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12930:
URL: https://github.com/apache/arrow/pull/12930#issuecomment-1107529305
Benchmark runs are scheduled for baseline = 1dccb56a8328abde60238a890f720d7cc642cc94 and contender = 36a7f114ce5826b911f58265ecfc8fab7bd8eddf. 36a7f114ce5826b911f58265ecfc8fab7bd8eddf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4863f4b2d71740af80e7d101e14f05bc...1d4402f103bf4d9ebeef3019f774dc8d/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5460e890f78744ecbb2fae606949504d...b332c1bc0662498eb706706d553fd816/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2250c666fc3f413bb7f2bfc3c41b6f14...f70ec27b516f42678ae60e470de2f467/)
[Finished :arrow_down:0.63% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0d7ef26475a947849524dd5746cf820a...98f8f2eaba6a4219b1cf3828559aabf8/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/568| `36a7f114` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/556| `36a7f114` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/554| `36a7f114` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/566| `36a7f114` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/567| `1dccb56a` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/555| `1dccb56a` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/553| `1dccb56a` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/565| `1dccb56a` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org