You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/05 06:10:43 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #1795: [IOTDB-933] Fix antlr4 which caused benchmark throw exception

HTHou commented on a change in pull request #1795:
URL: https://github.com/apache/iotdb/pull/1795#discussion_r499362773



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##########
@@ -1297,10 +1297,15 @@ public void enterFunctionElement(FunctionElementContext ctx) {
   public void enterSelectElement(SelectElementContext ctx) {
     super.enterSelectElement(ctx);
     selectOp = new SelectOperator(SQLConstant.TOK_SELECT);
-    List<SuffixPathContext> suffixPaths = ctx.suffixPath();
-    for (SuffixPathContext suffixPath : suffixPaths) {
-      PartialPath path = parseSuffixPath(suffixPath);
-      selectOp.addSelectPath(path);
+    List<SqlBaseParser.SuffixPathOrConstantContext> suffixPathOrConstants = ctx.suffixPathOrConstant();
+    for (SqlBaseParser.SuffixPathOrConstantContext suffixPathOrConstant : suffixPathOrConstants) {
+      if(suffixPathOrConstant.suffixPath() != null){

Review comment:
       ```suggestion
         if (suffixPathOrConstant.suffixPath() != null) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org